Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README and other documentation #711
Update README and other documentation #711
Changes from 3 commits
c1b6089
5143fff
5d51c39
9aced42
7caa2b7
7e5d4dd
de5c6c7
348b32f
f04a4b8
1b3d486
f3afcc5
7553ed7
12d0ab9
a76f27b
6354f2a
05e249f
cb17c26
3a4efec
04a50f5
4a2f95e
768a6bc
c6fca01
09535f4
75a5284
3786f58
872e63a
8c17ab8
8b3ea4e
364462e
5b708e8
66ed05e
06855fb
5d8f42b
c1a08b8
51d977c
18452bc
e001a35
6038fe4
dcf24a3
27edfe8
5a3ca42
360a157
69351a3
f618dbc
baaa5c8
ba7fb53
740b770
f53e2ed
116b910
d86d5f5
2003968
5822d62
ab4caa7
42559b4
3e55c05
c65d456
d791b50
06abc3c
d540657
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this implies some level of USO engagement. I think we might want to set it to "unsupported" and have a broader discussion about levels of support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, good point. Lets think about this some more...I'll see if I can dig up the specifics on when to use each level of service. I hate to put that this isn't supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it would be much better to say "community supported". I brought this up in Slack with @asteiker this week, but she's really busy with IS2 hack week. Maybe will get some feedback on that soon!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this section for now, pending further discussions at NSIDC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link to issue page here? Also link to our contributing document? Should we move the contributing section here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The LICENSE is called out in the "Level of Support". I thought this had been under its own section, maybe we revised the template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I honestly don't feel we need to reference the
LICENSE
in the README at all, but maybe not all would agree.The file name is all-caps, so it's practically already screaming at me, and GitHub automatically recognizes the file and displays a special link for it anyway.
If this is the way it is in the template, maybe we should have that discussion via an issue over there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, you may be right. This is language taken directly from the template README.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Requirements", "Installation", and "Usage" sections are all for QGreenland, not the code here. Is that confusing? The layout of our ReadTheDocs does a good job of distinguishing between user and contributor documentation and includes all of the information here. We should really just have very top-level information here with links to RTD.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! I think we should keep the GitHub README focused on being the face of the code, and link out to RTD for user-targeted stuff.