-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pqdm_kwargs integration tests #866
Conversation
Does it have something to do with our magic code that allows 10% of integration tests to fail? 😆 |
I don't think so. Something very odd seems to be happening, and I can't figure it out. The code in this PR passes all unit and integration tests when I run them locally with It appears my attempt to "fix" the recent integration test failures has only produced even more failures. I'm still digging to see what's up. |
Want to pair on it sometime this week? |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files@@ Coverage Diff @@
## main #866 +/- ##
===========================================
- Coverage 73.88% 58.72% -15.17%
===========================================
Files 31 13 -18
Lines 2003 1100 -903
===========================================
- Hits 1480 646 -834
+ Misses 523 454 -69 ☔ View full report in Codecov by Sentry. |
@mfisher87, I discovered one of the problems, which was that the unit tests that were added for the original pqdm_kwargs work should have been integration tests instead. The unit tests were failing because they were waiting for interactive input of creds for login. I have moved them (and tweaked them) to be integration tests, so now they are passing. However, what's puzzling now is why are integration tests failing? What I've discovered by looking at the most recent failure is that the integration test jobs are not running the most recent code that I've pushed. I am coming to this conclusion because of the following:
Oddly, it appears that the code being run is coming from nsidc:main, not from chuckwondo:fix-pqdm-kwargs. I might simply close this PR and open a new one to see if that fixes the problem. |
Closing this PR to see if opening a new one gets past the odd behavior I'm seeing in this one. |
Integration tests are failing, with many errors of the following form:
This PR fixes this issue, although it's odd that the integration tests did not fail prior to the code landing on
main
that is now causing this problem.It turns out to be an issue with use of singledispatch, and having registered functions with signatures that differed (accidentally, it seems) by more than simply a difference of type of the first argument.
📚 Documentation preview 📚: https://earthaccess--866.org.readthedocs.build/en/866/