Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unused format script #838

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Drop unused format script #838

merged 2 commits into from
Oct 4, 2024

Conversation

jhkennedy
Copy link
Collaborator

@jhkennedy jhkennedy commented Oct 3, 2024

In this PR, I've:

  • Removed scripts/format.sh as we currently don't document it and instead use Pre-Commit to run ruff
  • Changed "Poetry" to "Pyproject.toml" in scripts/verify_tag.sh as we don't use poetry anymore.

I don't think either of these changes needs a changelog entry.

Pull Request (PR) draft checklist - click to expand
  • Please review our
    contributing documentation
    before getting started.
  • Ensure an issue exists representing the problem being solved in this PR.
  • Populate a descriptive title. For example, instead of "Updated README.md", use a
    title such as "Add testing details to the contributor section of the README".
    Example PRs: #763
  • Populate the body of the pull request with:
  • Update CHANGELOG.md with details about your change in a section titled
    ## Unreleased. If such a section does not exist, please create one. Follow
    Common Changelog for your additions.
    Example PRs: #763
  • Update the documentation and/or the README.md with details of changes to the
    earthaccess interface, if any. Consider new environment variables, function names,
    decorators, etc.

Click the "Ready for review" button at the bottom of the "Conversation" tab in GitHub
once these requirements are fulfilled. Don't worry if you see any test failures in
GitHub at this point!

Pull Request (PR) merge checklist - click to expand

Please do your best to complete these requirements! If you need help with any of these
requirements, you can ping the @nsidc/earthaccess-support team in a comment and we
will help you out!

  • Add unit tests for any new features.
  • Apply formatting and linting autofixes. You can add a GitHub comment in this Pull
    Request containing "pre-commit.ci autofix" to automate this.
  • Ensure all automated PR checks (seen at the bottom of the "conversation" tab) pass.
  • Get at least one approving review.

📚 Documentation preview 📚: https://earthaccess--838.org.readthedocs.build/en/838/

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.85%. Comparing base (2f49c08) to head (7711b72).
Report is 33 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #838      +/-   ##
==========================================
- Coverage   73.88%   73.85%   -0.04%     
==========================================
  Files          31       31              
  Lines        2003     2004       +1     
==========================================
  Hits         1480     1480              
- Misses        523      524       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jhkennedy jhkennedy marked this pull request as ready for review October 3, 2024 01:56
mfisher87
mfisher87 previously approved these changes Oct 4, 2024
Copy link
Collaborator

@mfisher87 mfisher87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Agreed on changelog.

scripts/verify_tag.sh Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Oct 4, 2024

Binder 👈 Launch a binder notebook on this branch for commit 7711b72

I will automatically update this comment whenever this PR is modified

@jhkennedy jhkennedy merged commit 45270c1 into nsidc:main Oct 4, 2024
13 checks passed
@jhkennedy jhkennedy deleted the scripts branch October 4, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants