Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update releasing docs from run-through with Nikki #834

Merged
merged 5 commits into from
Oct 2, 2024

Conversation

mfisher87
Copy link
Collaborator

@mfisher87 mfisher87 commented Oct 1, 2024

We discovered an issue: #833 but chose to skip over that problem by giving Nikki temporary (already-revoked) privileges to bypass branch protection. The doc is updated assuming that one can actually push directly to main, but I think we should switch to doing all releases in PRs and update the doc accordingly. What does everyone think?


📚 Documentation preview 📚: https://earthaccess--834.org.readthedocs.build/en/834/

@mfisher87 mfisher87 requested a review from nikki-t October 1, 2024 18:32
@mfisher87
Copy link
Collaborator Author

This isn't rendering nicely in Mkdocs. Needs fix!

nikki-t
nikki-t previously approved these changes Oct 1, 2024
Copy link
Collaborator

@nikki-t nikki-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments on some suggestion but I think the updated documentation on the release process look great!

docs/contributing/releasing.md Show resolved Hide resolved
docs/contributing/releasing.md Show resolved Hide resolved
@mfisher87
Copy link
Collaborator Author

Fixed up the formatting in Mkdocs! 5b84afc

@mfisher87 mfisher87 requested a review from nikki-t October 2, 2024 15:31
@nikki-t
Copy link
Collaborator

nikki-t commented Oct 2, 2024

Looks great!

@mfisher87 mfisher87 merged commit 757f9b9 into main Oct 2, 2024
16 checks passed
@mfisher87 mfisher87 deleted the update-releasing-docs branch October 2, 2024 18:13
@mfisher87
Copy link
Collaborator Author

Thanks, @nikki-t !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants