-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable integration test workflow to more clearly communicate failure #738
Conversation
Returned to draft; it was failing loudly in Act, but looks like still failing silently in GHA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing, I don't know when we started to exclude the integration tests!
Is there any reason not to merge? if the tests fail we should fix them. Maybe we need to visit the option to define a few popular datasets per DAAC instead of using random samples because some of them fail. |
I think at minimum we need to update the fixture that allows 10% failure to communicate clearly that it was invoked before merging this one. Since it's a lot of work to rework the tests to remove that rule, this seems like a reasonable step. I'll try and take a look at that soon. |
… calls Allow f-strings in log calls.
@betolink please take a look!
|
pre-commit.ci autofix |
Resolves #737
I don't have free time to debug the actual failures. Just getting the tests to fail loudly was a headache 😆 At a glance, I see a couple problems: