Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "Common Changelog" format for Changelog #584

Conversation

danielfromearth
Copy link
Collaborator

@danielfromearth danielfromearth commented May 29, 2024

Resolves #554.

Use Common Changelog.

For instance, this change:

  • recategorizes entries into "Common Changelog" groups
  • formats headings
  • uses an imperative mood
  • adds author tags to each entry

This PR also adds a few missing entries to older release sections.


📚 Documentation preview 📚: https://earthaccess--584.org.readthedocs.build/en/584/

@danielfromearth danielfromearth linked an issue May 29, 2024 that may be closed by this pull request
@danielfromearth
Copy link
Collaborator Author

@jhkennedy, @mfisher87 — following up from a mention of this yesterday — any suggestions for linting of markdown in a CI pipeline?

@danielfromearth danielfromearth added the documentation Improvements or additions to documentation label May 29, 2024
@danielfromearth danielfromearth self-assigned this May 29, 2024
@mfisher87
Copy link
Collaborator

mfisher87 commented May 29, 2024

I'm OK with bringing prettier back for formatting markdown (no strong feelings on whether we go back to using it for YAML. The new formatter we're using for YAML is more configurable). We may want to find a different mirror than the archived official pre-commit one. Several folks have already forked it (e.g. https://github.com/rbubley/mirrors-prettier) to remove the alpha/beta versions that were causing us problems.

I do feel it's important to use a formatter for accessibility. It would be nice to also add a linter, if it's compatible with our formatter, to catch only-human-fixable things like broken links, but maybe we could treat that as a separate issue.

@jhkennedy
Copy link
Collaborator

When we had looked into markdown linting before, we settled on this one as being the best option:
https://github.com/DavidAnson/markdownlint

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@danielfromearth
Copy link
Collaborator Author

Thanks @chuckwondo for spotting these, and I will incorporate those changes! I'm actually still working through the changelog entry-by-entry, and I'm currently about half-way through.

Another note to address (maybe there will be more as I get to more recent entries): I don't see the following changes listed in the changelog. Perhaps another person can double-check whether they should be added...

I think they would go in the [0.5.3] - 2023-08-01 section:

@danielfromearth
Copy link
Collaborator Author

@chuckwondo
Copy link
Collaborator

Thanks @chuckwondo for spotting these, and I will incorporate those changes! I'm actually still working through the changelog entry-by-entry, and I'm currently about half-way through.

Another note to address (maybe there will be more as I get to more recent entries): I don't see the following changes listed in the changelog. Perhaps another person can double-check whether they should be added...

I think they would go in the [0.5.3] - 2023-08-01 section:

There may be a few of the above (and likely others not listed above) that can be removed from the changelog.

For example, there's likely no need to included these:

These are likely classified as "noise," as they have no impact on users. See Remove noise. Please review existing entries, as well as entries you're considering adding, against the "noise" criteria to determine if existing ones can be removed, and whether or not missing entries should be added.

@danielfromearth
Copy link
Collaborator Author

pre-commit.ci autofix

@danielfromearth danielfromearth marked this pull request as ready for review July 9, 2024 15:27
@danielfromearth
Copy link
Collaborator Author

danielfromearth commented Jul 9, 2024

@chuckwondo, @mfisher87, I added a couple of the missing entries mentioned above, but left out the ones that seemed like they would be uninteresting to anyone other than the developers.

I think this is ready to merge! Was more work than I thought it would be to go through all the entries and cross-check them against the PR and issue lists on GitHub. I tried my best to capture who contributed to each PR/issue, and be as inclusive as possible, but if I missed someone, know that it wasn't intentional. Hopefully this is much better now, and gives credit to all the effort people have been doing to keep this awesome tool going and improving.

@mfisher87
Copy link
Collaborator

@danielfromearth AMAZING work!!! I appreciate that this is very hard and time consuming. Also worth it to show appreciation for everyone's work. I haven't had a chance to review this yet, but I'd like to make time for that in today's hack day and have a "merge party" :) Will you be there?

@mfisher87 mfisher87 added the hackathon An issue we'd like to visit during a hackathon event label Jul 9, 2024
@danielfromearth
Copy link
Collaborator Author

Thanks @mfisher87 :)
We have some ESIP Openscapes preparation time scheduled at the same time as the first half of the hack day, but I should be there for the second half of the hack day.

@mfisher87
Copy link
Collaborator

Awesome. I want to spend some time on integration tests today too so I'll try and get that out of the way first ;)

mfisher87
mfisher87 previously approved these changes Jul 9, 2024
@mfisher87
Copy link
Collaborator

Some discussion reflecting on the use of an "unreleased" section the way we do: vweevers/common-changelog#13

@mfisher87 mfisher87 dismissed chuckwondo’s stale review July 9, 2024 18:45

Change requests addressed

@mfisher87 mfisher87 merged commit 7a79ea5 into main Jul 9, 2024
16 checks passed
@mfisher87 mfisher87 deleted the issue-554-update-changelogmd-to-follow-common-changelog-conventions branch July 9, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation hackathon An issue we'd like to visit during a hackathon event
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CHANGELOG.md to follow Common Changelog conventions
4 participants