fix(install-node): use pre built binary nvm install #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
barbados-clemens
commented
Sep 30, 2024
•
barbados-clemens
commented
- fix(install-node): only install node with prebuild binaries
- chore(repo): update lock file and build output
- unsure why this changes happened. maybe got out of sync from a force push by accident??
Nx Agents arch should always have a pre-built binary, no need to waste time accidently building from scratch and should fail fast instead.
I just ran yarn after cloning and git push when ran build-all and got a new output 🤷
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 20bd48d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
barbados-clemens
changed the title
llwt
approved these changes
Sep 30, 2024
rarmatei
approved these changes
Oct 1, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
* fix(install-node): only install node with prebuild binaries Nx Agents arch should always have a pre-built binary, no need to waste time accidently building from scratch and should fail fast instead. * chore(repo): update lock file and build output I just ran yarn after cloning and git push when ran build-all and got a new output 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.