Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nrf54h20 flpr fixes #2433

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hubertmis
Copy link
Contributor

Write-back cache after copying VPR's code and data to the destination memory. It allows VPRs to run from RAM regions cacheable by its host.

It allows to use FLPR in nRF54H20.

Upstream PR #: 84104

Write-back cache after copying VPR's code and data to the destination
memory. It allows VPRs to run from RAM regions cacheable by its host.

It allows to use FLPR in nRF54H20.

Upstream PR #: 84104

Signed-off-by: Hubert Miś <[email protected]>
@hubertmis hubertmis force-pushed the pr/vpr-launcher-cache-management branch from e3e8067 to 6798c8d Compare January 16, 2025 20:24
@karstenkoenig
Copy link
Contributor

Can you please add in this here to fix the stacking sequence?
zephyrproject-rtos/zephyr@7523ebd

Copy link
Contributor

@karstenkoenig karstenkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a bunch of vpr related fixes now that are all relevant for nrf54h20 and so will also need a backport. We could avoid long CI runtimes and a big number of PRs by just collecting them all here.
Mandatory
zephyrproject-rtos/zephyr#84104
zephyrproject-rtos/zephyr#83997
zephyrproject-rtos/zephyr#84076
Optional
zephyrproject-rtos/zephyr#83940

@karstenkoenig
Copy link
Contributor

Note @lstnl there is more vpr related fixes, this here is to fix missing cache handling. I think we should group them into a single PR including your esf fix

EngB+ uses 32bit bus-width stacking sequence for all VPR cores.

Signed-off-by: Karsten Koenig <[email protected]>
(cherry picked from commit 620188224294aa19853aac7f9e9b545cb595d08d)
@hubertmis hubertmis changed the title [nrf fromlist] drv: nordic_vpr_launcher: manage data cache nrf54h20 flpr fixes Jan 17, 2025
Copy link
Contributor

@karstenkoenig karstenkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussion agreed to keep zephyrproject-rtos/zephyr#84076 out due to criticality of that. Thanks for cherry-picking the stacking order change in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants