[nrf fromtree] Bluetooth: add missing initilization of sync_info member #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NordicBuilder
requested review from
alwa-nordic,
asbjornsabo,
hermabe,
jori-nordic,
kruithofa,
Thalley and
theob-pro
jori-nordic
approved these changes
Mar 8, 2024
hermabe
approved these changes
Mar 8, 2024
alwa-nordic
approved these changes
Mar 8, 2024
ivaniushkov
force-pushed
the
fix_ubsan_warnings_past_scan
branch
2 times, most recently
from
be20710 to
fdfedd3
Compare
ivaniushkov
requested review from
anangl,
carlescufi,
gmarull,
jciupis,
rlubos,
jukkar,
de-nordic,
koffes,
alexsven,
erikrobstad,
rick1082 and
gWacey
as code owners
ivaniushkov
removed request for
a team,
koffes,
jukkar,
lemrey,
Thalley,
carlescufi,
anangl,
rlubos,
rick1082,
gmarull,
jciupis,
asbjornsabo,
alexsven,
de-nordic,
kruithofa,
erikrobstad,
gWacey and
theob-pro
During manual testing with UBSAN enabled, it was found that bt_le_per_adv_sync_cb synced() callback in application sometimes gets unexpected different values in `sync_info.recv_enabled` field. The UBSAN output contained the following warnings message: runtime error: load of value 65, which is not a valid value for type '_Bool' It tunrned out that struct bt_le_per_adv_sync_synced_info sync_info inside bt_hci_le_past_received_common() contains uninitialized recv_enabled member. Set it to true by default to avoid possible issues. Signed-off-by: Ivan Iushkov <[email protected]> (cherry picked from commit 76050859d41d031b78b737ef41640e1fb77f686a) Signed-off-by: Ivan Iushkov <[email protected]>
ivaniushkov
force-pushed
the
fix_ubsan_warnings_past_scan
branch
from
fdfedd3 to
f099bb1
Compare
NordicBuilder
requested review from
asbjornsabo,
kruithofa,
Thalley and
theob-pro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During manual testing with UBSAN enabled, it was found that bt_le_per_adv_sync_cb synced() callback in application sometimes gets unexpected different values in
sync_info.recv_enabledfield.The UBSAN output contained the following warnings message: runtime error:
load of value 65, which is not a valid value for type '_Bool'
It tunrned out that struct bt_le_per_adv_sync_synced_info sync_info inside bt_hci_le_past_received_common() contains uninitialized recv_enabled member.
Set it to true by default to avoid possible issues.
(cherry picked from commit 76050859d41d031b78b737ef41640e1fb77f686a)