-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrf fromlist] kconfig: shell: increase shell stack size for OpenThread #1560
Conversation
80ba1f3
to
8af5f40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it fix stack size for NCS or native Zephyr?
For NCS. Currently shell stack size is too small for some variants causing overflow on openthread samples |
Then it is better to resolve it in NCS not in Zephyr, maybe like other application and samples in NCS do it. How many releases will the stack be sufficient and we see another fromlist patch? |
This is a bugfix. As it can be seen in changed file, value of stack size is not changed. Incorrect assigning of value for opentrhead with no joiner functionality has been removed. PR has been approved upstream. Resolving it in NCS would only cause doubling of configs with the same value. |
Your commit message: "Shell stack size is too low for OpenThread without joiner
Is it just me who sees two different statements?
But you answer to my question "Does it fix stack size for NCS or native Zephyr?" is "For NCS.". According to you answer this value does not applies to native Zephyr RTOS but to NCS only, therefore is should be fixed in NCS. Also changed here: 4b94355 |
I discussed with @maciejbaczmanski and we agreed that this does apply upstream. The commit message will be amended. |
Shell stack size is too low for OpenThread without joiner functionality, causing overflow. In this commit, the value of stack size is not changed. Incorrect assigning of value for opentrhead with no joiner functionality has been removed. Upstream PR: zephyrproject-rtos/zephyr#69783 Signed-off-by: Maciej Baczmanski <[email protected]> (cherry picked from commit c346df93cf8d8a3be8a82fd2b23ae083dda64abb)
8af5f40
to
7e998e5
Compare
okay. I will merged it asap depending on rebase process. |
Shell stack size is too low for OpenThread without joiner functionality, causing overflow. This commit increases it.
upstream PR: zephyrproject-rtos/zephyr#69783
Signed-off-by: Maciej Baczmanski [email protected]
(cherry picked from commit 4fb493e49fef245e62df21620382e027a7200907)