Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build system changes #551

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Build system changes #551

merged 2 commits into from
Apr 25, 2024

Conversation

ktaborowski
Copy link
Contributor

@ktaborowski ktaborowski commented Apr 22, 2024 •
edited
Loading

#541 preparing build system to changes with sysbuild, but on child images

CI parameters

(branch, hash, pull/XXX/head)
NRF_revision=main

manifest-pr-skip (remove this line to create PR in NRF)

Description

JIRA ticket:

Self review

  • There is no commented code.
  • There are no TODO/FIXME comments without associated issue ticket.
  • Commits are properly organized.
  • Change has been tested.
  • Tests were updated (if applicable).

@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. source PR changing src files labels Apr 22, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 22, 2024 •
edited
Loading

Sample diff used total
nrf54l15pdk_nrf54l15_cpuapp:sample.sidewalk.dut RAM 0 B 121.49 KB 256 KB
ROM -60 B 413.08 KB 730 KB
nrf54l15pdk_nrf54l15_cpuapp:sample.sidewalk.hello RAM 0 B 87.86 KB 256 KB
ROM -60 B 349.53 KB 730 KB
nrf54l15pdk_nrf54l15_cpuapp:sample.sidewalk.hello.ble_only RAM 0 B 87.86 KB 256 KB
ROM -60 B 349.28 KB 730 KB
nrf54l15pdk_nrf54l15_cpuapp:sample.sidewalk.hello.ble_only.release RAM 0 B 83.02 KB 256 KB
ROM -48 B 284.49 KB 730 KB
nrf54l15pdk_nrf54l15_cpuapp:sample.sidewalk.hello.no_dfu RAM -74.59 KB 0 B 256 KB
ROM -330.76 KB 0 B 1.48 MB
nrf54l15pdk_nrf54l15_cpuapp:sample.sidewalk.hello.release RAM 0 B 83.02 KB 256 KB
ROM -48 B 284.61 KB 730 KB
thingy53_nrf5340_cpuapp:sample.sidewalk.demo.ble_only RAM 0 B 102.42 KB 440 KB
ROM -8 B 390.95 KB 975.5 KB
nrf52840dk_nrf52840:sample.sidewalk.demo RAM 0 B 119.83 KB 256 KB
ROM -12 B 494.69 KB 983.5 KB
nrf52840dk_nrf52840:sample.sidewalk.demo.ble_only RAM 0 B 104.33 KB 256 KB
ROM -12 B 412.42 KB 983.5 KB
nrf52840dk_nrf52840:sample.sidewalk.dut RAM 0 B 143.21 KB 256 KB
ROM -12 B 552.96 KB 983.5 KB
nrf52840dk_nrf52840:sample.sidewalk.hello RAM 0 B 109.71 KB 256 KB
ROM -8 B 494.29 KB 983.5 KB
nrf52840dk_nrf52840:sample.sidewalk.hello.ble_only RAM 0 B 94.21 KB 256 KB
ROM -12 B 411.82 KB 983.5 KB
nrf52840dk_nrf52840:sample.sidewalk.hello.no_dfu RAM -96.29 KB 0 B 256 KB
ROM -476.43 KB 0 B 1012 KB
nrf5340dk_nrf5340_cpuapp:sample.sidewalk.demo RAM 0 B 108.09 KB 440 KB
ROM -12 B 433.09 KB 975.5 KB
nrf5340dk_nrf5340_cpuapp:sample.sidewalk.demo.ble_only RAM 0 B 92.89 KB 440 KB
ROM -8 B 354.45 KB 975.5 KB
nrf5340dk_nrf5340_cpuapp:sample.sidewalk.dut RAM 0 B 131.55 KB 440 KB
ROM -12 B 491.4 KB 975.5 KB
nrf5340dk_nrf5340_cpuapp:sample.sidewalk.hello RAM 0 B 98.18 KB 440 KB
ROM -8 B 432.8 KB 975.5 KB
nrf5340dk_nrf5340_cpuapp:sample.sidewalk.hello.ble_only RAM 0 B 82.97 KB 440 KB
ROM -12 B 354.1 KB 975.5 KB
nrf5340dk_nrf5340_cpuapp:sample.sidewalk.hello.no_dfu RAM -84.95 KB 0 B 448 KB
ROM -414.75 KB 0 B 1008 KB
nrf54l15pdk_nrf54l15_cpuapp:sample.sidewalk.demo RAM 0 B 97.82 KB 256 KB
ROM -60 B 350.11 KB 730 KB
nrf54l15pdk_nrf54l15_cpuapp:sample.sidewalk.demo.ble_only RAM 0 B 97.82 KB 256 KB
ROM -60 B 349.86 KB 730 KB
.config diff 

./manual-tests-artifacts/twister-out/nrf54l15pdk_nrf54l15_cpuapp/log/sidewalk.test.log/zephyr/.config
old                                                            |new
							      >	CONFIG_DT_HAS_NORDIC_NRF_SAADC_ENABLED=y
							      >	CONFIG_HAS_HW_NRF_SAADC=y
							      >	CONFIG_NRF_GRTC_TIMER_AUTO_KEEP_ALIVE=y

./manual-tests-artifacts/twister-out/nrf54l15pdk_nrf54l15_cpuapp/ble/sidewalk.test.ble/zephyr/.config
old                                                            |new
							      >	CONFIG_DT_HAS_NORDIC_NRF_SAADC_ENABLED=y
							      >	CONFIG_HAS_HW_NRF_SAADC=y
							      >	CONFIG_NRF_GRTC_TIMER_AUTO_KEEP_ALIVE=y

./manual-tests-artifacts/twister-out/nrf54l15pdk_nrf54l15_cpuapp/simple_bootloader/sidewalk.test.simple_bootloader/zephyr/.config
old                                                            |new
							      >	CONFIG_DT_HAS_NORDIC_NRF_SAADC_ENABLED=y
							      >	CONFIG_HAS_HW_NRF_SAADC=y
							      >	CONFIG_NRF_GRTC_TIMER_AUTO_KEEP_ALIVE=y

./sample-artifacts-meta/twister-out/nrf54l15pdk_nrf54l15_cpuapp/sid_end_device/sample.sidewalk.hello.release/mcuboot/zephyr/.config
old                                                            |new
							      >	CONFIG_DT_HAS_NORDIC_NRF_SAADC_ENABLED=y
							      >	CONFIG_HAS_HW_NRF_SAADC=y
							      >	CONFIG_NRF_GRTC_TIMER_AUTO_KEEP_ALIVE=y

./sample-artifacts-meta/twister-out/nrf54l15pdk_nrf54l15_cpuapp/sid_end_device/sample.sidewalk.hello.release/zephyr/.config
old                                                            |new
							      >	CONFIG_DT_HAS_NORDIC_NRF_SAADC_ENABLED=y
							      >	CONFIG_HAS_HW_NRF_SAADC=y
							      >	CONFIG_NRF_GRTC_TIMER_AUTO_KEEP_ALIVE=y

./sample-artifacts-meta/twister-out/nrf54l15pdk_nrf54l15_cpuapp/sid_end_device/sample.sidewalk.hello.ble_only.release/mcuboot/zephyr/.config
old                                                            |new
							      >	CONFIG_DT_HAS_NORDIC_NRF_SAADC_ENABLED=y
							      >	CONFIG_HAS_HW_NRF_SAADC=y
							      >	CONFIG_NRF_GRTC_TIMER_AUTO_KEEP_ALIVE=y

./sample-artifacts-meta/twister-out/nrf54l15pdk_nrf54l15_cpuapp/sid_end_device/sample.sidewalk.hello.ble_only.release/zephyr/.config
old                                                            |new
							      >	CONFIG_DT_HAS_NORDIC_NRF_SAADC_ENABLED=y
							      >	CONFIG_HAS_HW_NRF_SAADC=y
							      >	CONFIG_NRF_GRTC_TIMER_AUTO_KEEP_ALIVE=y

./sample-artifacts-meta/twister-out/nrf54l15pdk_nrf54l15_cpuapp/sid_end_device/sample.sidewalk.demo.ble_only/mcuboot/zephyr/.config
old                                                            |new
							      >	CONFIG_DT_HAS_NORDIC_NRF_SAADC_ENABLED=y
							      >	CONFIG_HAS_HW_NRF_SAADC=y
							      >	CONFIG_NRF_GRTC_TIMER_AUTO_KEEP_ALIVE=y

./sample-artifacts-meta/twister-out/nrf54l15pdk_nrf54l15_cpuapp/sid_end_device/sample.sidewalk.demo.ble_only/zephyr/.config
old                                                            |new
							      >	CONFIG_DT_HAS_NORDIC_NRF_SAADC_ENABLED=y
							      >	CONFIG_HAS_HW_NRF_SAADC=y
							      >	CONFIG_NRF_GRTC_TIMER_AUTO_KEEP_ALIVE=y

./sample-artifacts-meta/twister-out/nrf54l15pdk_nrf54l15_cpuapp/sid_end_device/sample.sidewalk.dut/mcuboot/zephyr/.config
old                                                            |new
							      >	CONFIG_DT_HAS_NORDIC_NRF_SAADC_ENABLED=y
							      >	CONFIG_HAS_HW_NRF_SAADC=y
							      >	CONFIG_NRF_GRTC_TIMER_AUTO_KEEP_ALIVE=y

./sample-artifacts-meta/twister-out/nrf54l15pdk_nrf54l15_cpuapp/sid_end_device/sample.sidewalk.dut/zephyr/.config
old                                                            |new
							      >	CONFIG_DT_HAS_NORDIC_NRF_SAADC_ENABLED=y
							      >	CONFIG_HAS_HW_NRF_SAADC=y
							      >	CONFIG_NRF_GRTC_TIMER_AUTO_KEEP_ALIVE=y

./sample-artifacts-meta/twister-out/nrf54l15pdk_nrf54l15_cpuapp/sid_end_device/sample.sidewalk.hello.ble_only/mcuboot/zephyr/.config
old                                                            |new
							      >	CONFIG_DT_HAS_NORDIC_NRF_SAADC_ENABLED=y
							      >	CONFIG_HAS_HW_NRF_SAADC=y
							      >	CONFIG_NRF_GRTC_TIMER_AUTO_KEEP_ALIVE=y

./sample-artifacts-meta/twister-out/nrf54l15pdk_nrf54l15_cpuapp/sid_end_device/sample.sidewalk.hello.ble_only/zephyr/.config
old                                                            |new
							      >	CONFIG_DT_HAS_NORDIC_NRF_SAADC_ENABLED=y
							      >	CONFIG_HAS_HW_NRF_SAADC=y
							      >	CONFIG_NRF_GRTC_TIMER_AUTO_KEEP_ALIVE=y

./sample-artifacts-meta/twister-out/nrf54l15pdk_nrf54l15_cpuapp/sid_end_device/sample.sidewalk.hello/mcuboot/zephyr/.config
old                                                            |new
							      >	CONFIG_DT_HAS_NORDIC_NRF_SAADC_ENABLED=y
							      >	CONFIG_HAS_HW_NRF_SAADC=y
							      >	CONFIG_NRF_GRTC_TIMER_AUTO_KEEP_ALIVE=y

./sample-artifacts-meta/twister-out/nrf54l15pdk_nrf54l15_cpuapp/sid_end_device/sample.sidewalk.hello/zephyr/.config
old                                                            |new
							      >	CONFIG_DT_HAS_NORDIC_NRF_SAADC_ENABLED=y
							      >	CONFIG_HAS_HW_NRF_SAADC=y
							      >	CONFIG_NRF_GRTC_TIMER_AUTO_KEEP_ALIVE=y

./sample-artifacts-meta/twister-out/nrf54l15pdk_nrf54l15_cpuapp/sid_end_device/sample.sidewalk.demo/mcuboot/zephyr/.config
old                                                            |new
							      >	CONFIG_DT_HAS_NORDIC_NRF_SAADC_ENABLED=y
							      >	CONFIG_HAS_HW_NRF_SAADC=y
							      >	CONFIG_NRF_GRTC_TIMER_AUTO_KEEP_ALIVE=y

./sample-artifacts-meta/twister-out/nrf54l15pdk_nrf54l15_cpuapp/sid_end_device/sample.sidewalk.demo/zephyr/.config
old                                                            |new
							      >	CONFIG_DT_HAS_NORDIC_NRF_SAADC_ENABLED=y
							      >	CONFIG_HAS_HW_NRF_SAADC=y
							      >	CONFIG_NRF_GRTC_TIMER_AUTO_KEEP_ALIVE=y

@ktaborowski
samples: Fix configuration scheme
c152387 
In this commit:
- Removed redundant prj_no_dfu.conf configuration.
- moved all pm_static files to samples main directories and
renamed them to be consistent with the NCS build system and
partition manager requirements.
- Updated documentation regarding the changes.

Signed-off-by: Krzysztof Taborowski <[email protected]>
@ktaborowski
samples: simplify sample yaml with common
48c351a 
[KRKNWK-18748]

Signed-off-by: Krzysztof Taborowski <[email protected]>
@ktaborowski ktaborowski force-pushed the build-system-changes branch from 8f94290 to 48c351a Compare April 25, 2024 08:17
@ktaborowski ktaborowski merged commit b7ba6dc into nrfconnect:main Apr 25, 2024
55 of 56 checks passed
@ktaborowski ktaborowski deleted the build-system-changes branch June 18, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertGalatNordic RobertGalatNordic RobertGalatNordic approved these changes

@nordicjm nordicjm Awaiting requested review from nordicjm

@totyz totyz Awaiting requested review from totyz

Assignees
No one assigned
Labels
doc-required PR must not be merged without tech writer approval. source PR changing src files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ktaborowski @RobertGalatNordic