Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rak4631dk nrf52840 #548

Closed
wants to merge 6 commits into from
Closed

Rak4631dk nrf52840 #548

wants to merge 6 commits into from

Conversation

ktaborowski
Copy link
Contributor

@ktaborowski ktaborowski commented Apr 19, 2024 •
edited by RobertGalatNordic
Loading

CI parameters

(branch, hash, pull/XXX/head)
NRF_revision=main

manifest-pr-skip (remove this line to create PR in NRF)

Github_actions:
  #(branch, hash, pull/XXX/head)
  NRF_revision: main

  # Do not change after creating PR
  Create_NRF_PR: false
Jenkins:
  test-sdk-sidewalk: master

Description

JIRA ticket:

Self review

  • There is no commented code.
  • There are no TODO/FIXME comments without associated issue ticket.
  • Commits are properly organized.
  • Change has been tested.
  • Tests were updated (if applicable).

@ktaborowski ktaborowski added the DNM Do Not Merge label Apr 19, 2024
@github-actions github-actions bot added the source PR changing src files label Apr 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 19, 2024 •
edited
Loading

Sample diff used total

Memory usage did not change for any of the samples.

.config diff 

./sample-artifacts-meta/twister-out/nrf52840dk_nrf52840/sid_end_device/sample.sidewalk.demo.ble_only/zephyr/.config
old                                                            |new
CONFIG_BT_DEVICE_NAME="Nordic"				      |	CONFIG_BT_DEVICE_NAME="RAK-46"

./sample-artifacts-meta/twister-out/nrf52840dk_nrf52840/sid_end_device/sample.sidewalk.dut/zephyr/.config
old                                                            |new
CONFIG_BT_DEVICE_NAME="Nordic"				      |	CONFIG_BT_DEVICE_NAME="RAK-46"

./sample-artifacts-meta/twister-out/nrf52840dk_nrf52840/sid_end_device/sample.sidewalk.hello.ble_only/zephyr/.config
old                                                            |new
CONFIG_BT_DEVICE_NAME="Nordic"				      |	CONFIG_BT_DEVICE_NAME="RAK-46"

./sample-artifacts-meta/twister-out/nrf52840dk_nrf52840/sid_end_device/sample.sidewalk.hello/zephyr/.config
old                                                            |new
CONFIG_BT_DEVICE_NAME="Nordic"				      |	CONFIG_BT_DEVICE_NAME="RAK-46"

./sample-artifacts-meta/twister-out/nrf52840dk_nrf52840/sid_end_device/sample.sidewalk.demo/zephyr/.config
old                                                            |new
CONFIG_BT_DEVICE_NAME="Nordic"				      |	CONFIG_BT_DEVICE_NAME="RAK-46"

./sample-artifacts-meta/twister-out/thingy53_nrf5340_cpuapp/sid_end_device/sample.sidewalk.demo.ble_only/zephyr/.config
old                                                            |new
CONFIG_BT_DEVICE_NAME="Nordic"				      |	CONFIG_BT_DEVICE_NAME="RAK-46"

./sample-artifacts-meta/twister-out/nrf5340dk_nrf5340_cpuapp/sid_end_device/sample.sidewalk.demo.ble_only/zephyr/.config
old                                                            |new
CONFIG_BT_DEVICE_NAME="Nordic"				      |	CONFIG_BT_DEVICE_NAME="RAK-46"

./sample-artifacts-meta/twister-out/nrf5340dk_nrf5340_cpuapp/sid_end_device/sample.sidewalk.dut/zephyr/.config
old                                                            |new
CONFIG_BT_DEVICE_NAME="Nordic"				      |	CONFIG_BT_DEVICE_NAME="RAK-46"

./sample-artifacts-meta/twister-out/nrf5340dk_nrf5340_cpuapp/sid_end_device/sample.sidewalk.hello.ble_only/zephyr/.config
old                                                            |new
CONFIG_BT_DEVICE_NAME="Nordic"				      |	CONFIG_BT_DEVICE_NAME="RAK-46"

./sample-artifacts-meta/twister-out/nrf5340dk_nrf5340_cpuapp/sid_end_device/sample.sidewalk.hello/zephyr/.config
old                                                            |new
CONFIG_BT_DEVICE_NAME="Nordic"				      |	CONFIG_BT_DEVICE_NAME="RAK-46"

./sample-artifacts-meta/twister-out/nrf5340dk_nrf5340_cpuapp/sid_end_device/sample.sidewalk.demo/zephyr/.config
old                                                            |new
CONFIG_BT_DEVICE_NAME="Nordic"				      |	CONFIG_BT_DEVICE_NAME="RAK-46"

./sample-artifacts-meta/twister-out/nrf54l15pdk_nrf54l15_cpuapp/sid_end_device/sample.sidewalk.demo.ble_only/zephyr/.config
old                                                            |new
CONFIG_BT_DEVICE_NAME="Nordic"				      |	CONFIG_BT_DEVICE_NAME="RAK-46"

./sample-artifacts-meta/twister-out/nrf54l15pdk_nrf54l15_cpuapp/sid_end_device/sample.sidewalk.dut/zephyr/.config
old                                                            |new
CONFIG_BT_DEVICE_NAME="Nordic"				      |	CONFIG_BT_DEVICE_NAME="RAK-46"

./sample-artifacts-meta/twister-out/nrf54l15pdk_nrf54l15_cpuapp/sid_end_device/sample.sidewalk.hello.ble_only/zephyr/.config
old                                                            |new
CONFIG_BT_DEVICE_NAME="Nordic"				      |	CONFIG_BT_DEVICE_NAME="RAK-46"

./sample-artifacts-meta/twister-out/nrf54l15pdk_nrf54l15_cpuapp/sid_end_device/sample.sidewalk.hello/zephyr/.config
old                                                            |new
CONFIG_BT_DEVICE_NAME="Nordic"				      |	CONFIG_BT_DEVICE_NAME="RAK-46"

./sample-artifacts-meta/twister-out/nrf54l15pdk_nrf54l15_cpuapp/sid_end_device/sample.sidewalk.demo/zephyr/.config
old                                                            |new
CONFIG_BT_DEVICE_NAME="Nordic"				      |	CONFIG_BT_DEVICE_NAME="RAK-46"

@ktaborowski
samples: add rak board
9659f9d 
it builds

Signed-off-by: Krzysztof Taborowski <[email protected]>
@ktaborowski
samples: update rak board pins
2fe08dd 
based on zephyr/boards/arm/rak4631_nrf52840/rak4631_nrf52840.dts
antena_enable unknow

Signed-off-by: Krzysztof Taborowski <[email protected]>
@ktaborowski
samples: add rak specyfic configuration
bb0a0d4 
enable rtt shell
change bt name

Signed-off-by: Krzysztof Taborowski <[email protected]>
@ktaborowski ktaborowski closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
DNM Do Not Merge source PR changing src files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ktaborowski