Bluetooth: Mesh: fix NO_ACTIONS scheduling

[HaavardRei]

If the Scheduler Setup Server receives a Scheduler Action Set message setting the next scheduled task to NO_ACTIONS, it will schedule the next task in line.

Previously, the "canceled" task would be executed if it was first in line.

[NordicBuilder]

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 6

Inputs:

Sources:

sdk-nrf: PR head: fe3772dc0061534852893881aab190e6966cf830

more details

sdk-nrf:

PR head: fe3772dc0061534852893881aab190e6966cf830
merge base: f36abd1818b4606e9d825bac64356764b5dca37d
target head (main): d73524b1a04bef31199c55bbcb3bc550c2a1e56a
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (2)

subsys
│  ├── bluetooth
│  │  ├── mesh
│  │  │  │ scheduler_srv.c
tests
│  ├── subsys
│  │  ├── bluetooth
│  │  │  ├── mesh
│  │  │  │  ├── scheduler_model
│  │  │  │  │  ├── action_planning
│  │  │  │  │  │  ├── src
│  │  │  │  │  │  │  │ main.c

Outputs:

Toolchain

Version: 342151af73
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:342151af73_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

• ◻️ Toolchain - Skipped: existing toolchain is used
• ✅ Build twister
  • sdk-nrf test count: 823
• ✅ Integration tests
  • ✅ test-fw-nrfconnect-ble_mesh

Disabled integration tests

• • desktop52_verification
  • doc-internal
  • test_ble_nrf_config
  • test-fw-nrfconnect-apps
  • test-fw-nrfconnect-ble_samples
  • test-fw-nrfconnect-boot
  • test-fw-nrfconnect-chip
  • test-fw-nrfconnect-fem
  • test-fw-nrfconnect-nfc
  • test-fw-nrfconnect-nrf-iot_lwm2m
  • test-fw-nrfconnect-nrf-iot_mosh
  • test-fw-nrfconnect-nrf-iot_positioning
  • test-fw-nrfconnect-nrf-iot_samples
  • test-fw-nrfconnect-nrf-iot_serial_lte_modem
  • test-fw-nrfconnect-nrf-iot_thingy91
  • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
  • test-fw-nrfconnect-nrf_crypto
  • test-fw-nrfconnect-ps
  • test-fw-nrfconnect-rpc
  • test-fw-nrfconnect-rs
  • test-fw-nrfconnect-tfm
  • test-fw-nrfconnect-thread
  • test-fw-nrfconnect-zigbee
  • test-low-level
  • test-sdk-audio
  • test-sdk-dfu
  • test-sdk-find-my
  • test-sdk-mcuboot
  • test-sdk-pmic-samples
  • test-sdk-sidewalk
  • test-sdk-wifi
  • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

[alxelax]

Action still remains in persistent memory. If this is periodic action, it will start again after reset device.

[HaavardRei]

Action still remains in persistent memory. If this is periodic action, it will start again after reset device.

Won't it be cleared here? https://github.com/nrfconnect/sdk-nrf/blob/main/subsys/bluetooth/mesh/scheduler_srv.c#L647
is_entry_defined returns false then store sets the data to NULL?

[alxelax]

LGTM just the minor comment

I suppose it is worth to provide PR link in Firesquad channel request, that customer can cherry-pick fix before release.

[HaavardRei]

LGTM just the minor comment

I suppose it is worth to provide PR link in Firesquad channel request, that customer can cherry-pick fix before release.

They're in-the-loop through Jira, I'll ping them once it's merged :)

[omkar3141]

Looks good to me.