This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
[nrf noup] zephyr: Fix reason code for locally generated disconnection #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krish2718
requested review from
jukkar,
rado17,
sachinthegreen and
rlubos
as code owners
fixup! [nrf noup] zephyr: Implement connect and disconnect events to Zephyr In case a use issues a disconnect for some reason, it will still send IEEE 802.11 reason code 3, which will show up as a Failure (non-zero status) in Zephyr, this should only be applicable if AP sends de-authentication with reason code as "3". Fix locally generated case to return success (the enum should also be renamed from "unspecified" to "local", but that will be handled in another PR). Fixes SHEL-2561. Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
force-pushed
the
fix_false_disc_fail
branch
from
2042179 to
4802e24
Compare
kapbh
approved these changes
Mar 5, 2024
sachinthegreen
approved these changes
Mar 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case a use issues a disconnect for some reason, it will still send IEEE 802.11 reason code 3, which will show up as a Failure (non-zero status) in Zephyr, this should only be applicable if AP sends de-authentication with reason code as "3".
Fix locally generated case to return success (the enum should also be renamed from "unspecified" to "local", but that will be handled in another PR).
Fixes SHEL-2561.