This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
Fixes for upmerge 01.03.2024 #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
rlubos
changed the title
rlubos
force-pushed
the
upmerge-01-03-2024
branch
from
ae704ae to
9d44467
Compare
rlubos
requested review from
krish2718,
jukkar,
rado17 and
sachinthegreen
as code owners
rlubos
force-pushed
the
upmerge-01-03-2024
branch
from
9d44467 to
0dd5310
Compare
jukkar
approved these changes
Mar 21, 2024
krish2718
reviewed
Mar 21, 2024
| #else /* defined(CONFIG_POSIX_API) */ | ||
| #include <zephyr/net/net_ip.h> | ||
| #include <zephyr/net/socket.h> | ||
| #endif /* defined(CONFIG_POSIX_API) */ | ||
| #include <zephyr/shell/shell.h> | ||
| #endif /* defined(CONFIG_ZEPHYR) */ | ||
|
|
||
| #define signal(a, b) (void)(b) |
There was a problem hiding this comment.
should this be for Zephyr only? or at least #ifndef signal
There was a problem hiding this comment.
or, actually, signal could be a function so ifndef won't work, better to pull it under Zephyr only.
sachinthegreen
approved these changes
Mar 21, 2024
Supplicant will now use POSIX signal implementation from Zephyr, the same wasy as it's done for the upstream (Zephyr) supplicant, as using libc signal conflicts on sigset_t type definition. Signed-off-by: Robert Lubos <[email protected]>
rlubos
force-pushed
the
upmerge-01-03-2024
branch
from
0dd5310 to
a90d6b5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now fixing twister only, it needs to be verified with downstream tests whether the change actually makes sense.Good to go from my PoV.