This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
[nrf noup] zephyr: Don't use heap for WPA cli #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relying on heap during OOM is bad, esp. for critical module like WPA supplicant, this can break the Wi-Fi. As the WPA supplicant stack is large enough and this buffer is free immediately after use, just use the stack. Fixes SHEL-2283. Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
requested review from
jukkar,
rado17,
sachinthegreen and
rlubos
as code owners
sachinthegreen
approved these changes
Feb 8, 2024
rado17
approved these changes
Feb 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relying on heap during OOM is bad, esp. for critical module like WPA supplicant, this can break the Wi-Fi.
As the WPA supplicant stack is large enough and this buffer is free immediately after use, just use the stack.
Fixes SHEL-2283.