This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
[nrf noup] zephyr: Handle socket close #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krish2718
force-pushed
the
wpas_recv_loop
branch
2 times, most recently
from
905559c to
bf36701
Compare
krish2718
requested review from
jukkar,
rado17,
sachinthegreen and
rlubos
as code owners
fixup! [nrf noup] zephyr: Add support for WPA CLI zephyr In some cases (interface is disabled) the control interface socket is closed but as we don't handle EoF control interface keeps receiving zero bytes from the socket continuously and this causes an infinite loop and starving other threads (even SHELL thread). So, treat 0 bytes recv as EoF as its a connected socket and unregister from eloop to avoid infinite loop of recv failures. Fixes SHEL-2320. Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
force-pushed
the
wpas_recv_loop
branch
from
bf36701 to
0ca6c26
Compare
sachinthegreen
approved these changes
Dec 15, 2023
jukkar
approved these changes
Dec 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixup! [nrf noup] zephyr: Add support for WPA CLI zephyr
In some cases we are receving zero bytes from the socket continuously this causes an infinite loop and starving other threads (even SHELL thread).
So, treat 0 bytes recv as EoF as its a connected socket and unregister from eloop to avoid infinite loop of recv failures.