fix!: pack prepare lifecycle script honors --ignore-scripts

BREAKING CHANGE: pack prepare lifecycle script honors `--ignore-scripts`
npm · Oct 15, 2024 · c4c5744 · c4c5744
1 parent f75da94
commit c4c5744
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 5 deletions.
diff --git a/lib/commands/pack.js b/lib/commands/pack.js
@@ -15,6 +15,7 @@ class Pack extends BaseCommand {
     'workspace',
     'workspaces',
     'include-workspace-root',
+    'ignore-scripts',
   ]
 
   static usage = ['<package-spec>']

diff --git a/node_modules/pacote/lib/dir.js b/node_modules/pacote/lib/dir.js
@@ -32,6 +32,9 @@ class DirFetcher extends Fetcher {
       if (!mani.scripts || !mani.scripts.prepare) {
         return
       }
+      if (this.opts.ignoreScripts) {
+        return
+      }
 
       // we *only* run prepare.
       // pre/post-pack is run by the npm CLI for publish and pack,

diff --git a/package-lock.json b/package-lock.json
@@ -11269,8 +11269,7 @@
     },
     "node_modules/pacote": {
       "version": "19.0.1",
-      "resolved": "https://registry.npmjs.org/pacote/-/pacote-19.0.1.tgz",
-      "integrity": "sha512-zIpxWAsr/BvhrkSruspG8aqCQUUrWtpwx0GjiRZQhEM/pZXrigA32ElN3vTcCPUDOFmHr6SFxwYrvVUs5NTEUg==",
+      "resolved": "git+ssh://[email protected]/npm/pacote.git#d8254e94eacf14b7b4c3f99f70e1a0463d9adfeb",
       "inBundle": true,
       "license": "ISC",
       "dependencies": {
@@ -17090,7 +17089,7 @@
         "@npmcli/arborist": "^8.0.0",
         "@npmcli/run-script": "^9.0.1",
         "npm-package-arg": "^12.0.0",
-        "pacote": "^19.0.0"
+        "pacote": "github:npm/pacote#reggi/ignore-scripts"
       },
       "devDependencies": {
         "@npmcli/eslint-config": "^5.0.1",

diff --git a/tap-snapshots/test/lib/docs.js.test.cjs b/tap-snapshots/test/lib/docs.js.test.cjs
@@ -3708,7 +3708,7 @@ npm pack <package-spec>
 Options:
 [--dry-run] [--json] [--pack-destination <pack-destination>]
 [-w|--workspace <workspace-name> [-w|--workspace <workspace-name> ...]]
-[-ws|--workspaces] [--include-workspace-root]
+[-ws|--workspaces] [--include-workspace-root] [--ignore-scripts]
 
 Run "npm help pack" for more info
 
@@ -3722,6 +3722,7 @@ npm pack <package-spec>
 #### \`workspace\`
 #### \`workspaces\`
 #### \`include-workspace-root\`
+#### \`ignore-scripts\`
 `
 
 exports[`test/lib/docs.js TAP usage ping > must match snapshot 1`] = `

diff --git a/workspaces/libnpmpack/package.json b/workspaces/libnpmpack/package.json
@@ -40,7 +40,7 @@
     "@npmcli/arborist": "^8.0.0",
     "@npmcli/run-script": "^9.0.1",
     "npm-package-arg": "^12.0.0",
-    "pacote": "^19.0.0"
+    "pacote": "github:npm/pacote#reggi/ignore-scripts"
   },
   "engines": {
     "node": "^20.17.0 || >=22.9.0"