Skip to content
This repository has been archived by the owner on May 27, 2022. It is now read-only.

Dart utf8 #125

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Dart utf8 #125

wants to merge 2 commits into from

Conversation

jerel
Copy link
Contributor

@jerel jerel commented Apr 5, 2022

Summary

Initial implementation of the Dart runtime handled string ser/de with [utf-16] code units. This had the appearance of working as long as the given character was < 128. This PR switches to utf-8 encode/decode to fix this bug.

Test Plan

A test is included with Japanese text which causes the current implementation to fail.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 5, 2022
@ma2bd
Copy link
Contributor

ma2bd commented Apr 5, 2022

Thanks! FYI we're in the process of moving this repo (I can't accept PRs here)

@jerel
Copy link
Contributor Author

jerel commented Apr 5, 2022

Ok, thanks for the update! Let me know if there's anything I can do such as opening against a different repo, etc.

@ma2bd
Copy link
Contributor

ma2bd commented Apr 12, 2022

@jerel Thanks. I would imagine the future repo to be github.com/zefchain/serde-reflection but I'm still waiting for confirmation on the migration process.

@jerel
Copy link
Contributor Author

jerel commented May 13, 2022

@ma2bd I'm curious what the prospect of a 0.3.6 release on crates.io is looking like? I have a downstream crate that depends on 0.3.5 and would like to fix this bug in that crate. Not trying to put any pressure on, just curious how things are looking.

@ma2bd
Copy link
Contributor

ma2bd commented May 13, 2022

@jerel Hi! Still no progress on an official repo migration. Can you make a PR on github.com/zefchain/serde-reflection ?

@jerel
Copy link
Contributor Author

jerel commented May 13, 2022

Yes, happy to do that.

And... done.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants