Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dart UDL for additional themes #280

Merged
merged 5 commits into from
Dec 2, 2024
Merged

Dart UDL for additional themes #280

merged 5 commits into from
Dec 2, 2024

Conversation

NBA2K1
Copy link
Contributor

@NBA2K1 NBA2K1 commented Dec 2, 2024

@pryrt pryrt added the needs improvement will be rejected if requested improvement isn't made label Dec 2, 2024
@pryrt
Copy link
Contributor

pryrt commented Dec 2, 2024

  1. Please rename the UDL filenames to not include parentheses (parentheses can mess up some of the automation, and aren't a good idea in filenames). Suggestions:
    • Dart_DarkModeDefault.xml
    • Dart_Catpuccin-Macchiato.xml
  2. Please update the udl-list.json, as per the CONTRIBUTING.md instructions

@pryrt pryrt added accepted and removed needs improvement will be rejected if requested improvement isn't made labels Dec 2, 2024
@pryrt pryrt merged commit 7081103 into notepad-plus-plus:master Dec 2, 2024
1 of 2 checks passed
@pryrt
Copy link
Contributor

pryrt commented Dec 2, 2024

The error was for a different UDL whose external download disappeared; as it is not the fault of this PR, I have accepted the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NBA2K1 @pryrt