Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved org maintainers to emeritus #919

Merged
merged 4 commits into from
Apr 2, 2024
Merged

Moved org maintainers to emeritus #919

merged 4 commits into from
Apr 2, 2024

Conversation

toddysm
Copy link
Contributor

@toddysm toddysm commented Apr 1, 2024 •
edited
Loading

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.35%. Comparing base (eaa5fb4) to head (ebac7cf).
Report is 19 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #919      +/-   ##
==========================================
+ Coverage   64.93%   67.35%   +2.42%     
==========================================
  Files          45       45              
  Lines        2729     2166     -563     
==========================================
- Hits         1772     1459     -313     
+ Misses        795      545     -250     
  Partials      162      162

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Two-Hearts
Two-Hearts previously approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi previously approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toddysm
Added new org maintainers
ebac7cf 
Signed-off-by: Toddy Mladenov <[email protected]>
@toddysm toddysm dismissed stale reviews from priteshbandi and Two-Hearts via ebac7cf April 2, 2024 01:05
JeyJeyGao
JeyJeyGao approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit fa0f5ba into notaryproject:main Apr 2, 2024
5 checks passed
This was referenced Jun 11, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeyJeyGao JeyJeyGao JeyJeyGao approved these changes

@priteshbandi priteshbandi priteshbandi approved these changes

@Two-Hearts Two-Hearts Two-Hearts left review comments

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@justincormack justincormack Awaiting requested review from justincormack

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@shizhMSFT shizhMSFT Awaiting requested review from shizhMSFT shizhMSFT is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@toddysm @codecov-commenter @priteshbandi @JeyJeyGao @Two-Hearts