Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reallocation of gl buffer #379

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mario-holubar
Copy link
Contributor

When buffer_update() is called with a size greater than the buffer's original size, reallocate it using glBufferData()

Or is the lack of this intentional to incentivize keeping buffers at a fixed size?

@not-fl3
Copy link
Owner

not-fl3 commented Jun 15, 2023

It was intentional, but if it is easy to make it works with a bigger buffer sizes - I don't really see why not.
The only question here - could it be done for metal backend? I am OK with changing this behavior, but it should be consistent across backends

@mario-holubar
Copy link
Contributor Author

Ah yeah that makes sense. I've never used Metal so I don't know if it's possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants