Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #4705. Viewer Index+ show right text with multiple objects and indices of objects #5000

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

satabol
Copy link
Collaborator

@satabol satabol commented Sep 22, 2023

Sverchok 1.3.0-alpha, Blender 3.6.1, Windows 11

fix #4705

  • waiting for ready to blender 4.0

Now Modes are good:

  1. Only indices for vertices, edges, faces without object indices
    image
    image
    image

  2. Indices for vertices, edges, faces with (!!!) object indices
    image
    image
    image

  3. Only text for vertices, edges, faces without object indices
    image
    image
    image)

  4. Text for vertices, edges, faces with (!!!) object indices
    image
    image
    image

Blend file for tests: issue_4705.example.blend.zip

@satabol
Copy link
Collaborator Author

satabol commented Sep 22, 2023

Hi @zeffii ! Can you test this pull request? I force to work this node in a mode with multiple objects with custom text and property "Draw Object Index" is On. But I think this node need global refactor ))) (not now)

P.S.
Also I simplify using shaders to a single shader draw_indices_2D_wbg without draw_indices_2D. draw_indices_2D is a very simple and it differ only by a background rectangle. May be draw_indices_2D is not need any more?

@satabol
Copy link
Collaborator Author

satabol commented Sep 23, 2023

All was hidden with that configuration of params:
image

image
Fixed.

@zeffii
Copy link
Collaborator

zeffii commented Sep 23, 2023

the ghost icon-button is for hiding backfacing indices, so only really works when user passes polygons too.

@satabol
Copy link
Collaborator Author

satabol commented Sep 23, 2023

I get this glitch after exclude draw_indices_2D. Now it is work good.

@satabol
Copy link
Collaborator Author

satabol commented Sep 29, 2023

Hi, @zeffii! May I ask you to view this PR?

@satabol satabol changed the title Viewer Index+ show right text with multiple objects and indices of objects fix #4705. Viewer Index+ show right text with multiple objects and indices of objects Oct 4, 2023
@zeffii
Copy link
Collaborator

zeffii commented Oct 8, 2023

@satabol sorry , i've been traveling and have not been spending much time near computers.

@zeffii
Copy link
Collaborator

zeffii commented Oct 8, 2023

i don't see anything i disagree with, but would prefer if #4983 was pushed first.

@satabol
Copy link
Collaborator Author

satabol commented Oct 8, 2023

Ok @zeffii. No problem. I will expect it. )))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Viewer Index+ show wrong text when use text input in edge and face mode with connect more than 1 object
2 participants