Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 4352. SvOB3BDataCollection should be registered only once #4986

Merged

Conversation

satabol
Copy link
Collaborator

@satabol satabol commented Aug 19, 2023

Sverchok 1.3.0-alpha, Blender 3.6.1, Windows 11.
#4352

Fixed several console error messages relied to [SvOB3BItemOperator, SvOB3BDataCollection, SVOB3B_UL_NamesList, SvOB3Callback].

image

Before fix:
image

Additionally was error message. No errors after split into two files:
image

After fix this error for [SvOB3BItemOperator, SvOB3BDataCollection, SVOB3B_UL_NamesList, SvOB3Callback] got visible and now no error messages.

@satabol satabol force-pushed the fix_4352_SvOB3BDataCollection_should_be_registered_only_once branch from d2103b9 to a08526f Compare August 19, 2023 19:40
@satabol satabol force-pushed the fix_4352_SvOB3BDataCollection_should_be_registered_only_once branch from a08526f to fcf9d57 Compare August 19, 2023 19:41
@satabol satabol requested a review from zeffii August 19, 2023 19:43
@satabol
Copy link
Collaborator Author

satabol commented Aug 19, 2023

Hi @zeffii. I spend some time for this issue ))). Can you check this fix?

@zeffii
Copy link
Collaborator

zeffii commented Aug 20, 2023

@satabol I also spent time on this issue more than a year ago, and seem to have given up. happy to review it.

should be OK i think! feel free to push it.

@satabol
Copy link
Collaborator Author

satabol commented Aug 20, 2023

A test of get/set property:

image

it is good.

@satabol satabol merged commit 29f929b into master Aug 20, 2023
1 check passed
@satabol satabol deleted the fix_4352_SvOB3BDataCollection_should_be_registered_only_once branch August 20, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants