Skip to content

Commit

Permalink
Remove obsolete noqa statements (#944)
Browse files Browse the repository at this point in the history
  • Loading branch information
ogenstad authored Jul 1, 2024
1 parent a304100 commit 859354b
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion nornir/core/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def run(

raise_on_error = (
raise_on_error if raise_on_error is not None else self.config.core.raise_on_error
) # noqa
)
if raise_on_error:
result.raise_on_error()
else:
Expand Down
2 changes: 1 addition & 1 deletion nornir/core/configuration.py
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ def configure(self) -> None:
"This can lead to unexpected logging results. "
"Please set logging.enabled config to False "
"to disable automatic Nornir logging configuration. Refer to "
"https://nornir.readthedocs.io/en/stable/configuration/index.html#logging" # noqa
"https://nornir.readthedocs.io/en/stable/configuration/index.html#logging"
)
warnings.warn(msg, ConflictingConfigurationWarning)

Expand Down
2 changes: 1 addition & 1 deletion nornir/core/exceptions.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

if TYPE_CHECKING:
from nornir.core.connection import Connection
from nornir.core.result import AggregatedResult, MultiResult, Result # noqa
from nornir.core.result import AggregatedResult, MultiResult, Result
from nornir.core.tasks import Task


Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,6 @@ ignore = [
"RSE102", # Unnecessary parentheses on raised exception
"RUF001", # String contains ambiguous `–` (EN DASH). Did you mean `-` (HYPHEN-MINUS)?
"RUF012", # Mutable class attributes should be annotated with `typing.ClassVar`
"RUF100", # Unused blanket `noqa` directive
"S701", # By default, jinja2 sets `autoescape` to `False`. Consider using `autoescape=True` or the `select_autoescape` function to mitigate XSS vulnerabilities.
"SLF001", # Private member accessed
"SIM108", # Use ternary operator `config = Config.from_file(config_file, **kwargs) if config_file else Config.from_dict(**kwargs)` instead of `if`-`else`-block
Expand Down

0 comments on commit 859354b

Please sign in to comment.