Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto set cursorline option when line number background config is active #194

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iysheng
Copy link

@iysheng iysheng commented Feb 5, 2020

Resolves #141

auto set cursorline when

let g:nord_cursor_line_number_background = 1

to reslove issue141 that don't show properly at some point

@iysheng iysheng changed the title Add set cursorline option (#141) Auto set cursorline option when let g:nord_cursor_line_number_background = 1 (#141) Feb 5, 2020
@arcticicestudio
Copy link
Contributor

Hi @iysheng 👋, thanks for your contribution 👍
I'll review the changes in the near future and get back to you.
My first thought was that a theme should not set any properties except highlighting groups, otherwise it can mess with the configuration of the user causing unexpected side-effects, but I'll check it out later if this one might be fine in most cases.

@iysheng
Copy link
Author

iysheng commented Feb 6, 2020

Hi @iysheng wave, thanks for your contribution +1
I'll review the changes in the near future and get back to you.
My first thought was that a theme should not set any properties except highlighting groups, otherwise it can mess with the configuration of the user causing unexpected side-effects, but I'll check it out later if this one might be fine in most cases.

😄 ok,thanks for your patient answer.

@svengreb svengreb changed the title Auto set cursorline option when let g:nord_cursor_line_number_background = 1 (#141) Auto set cursorline option when line number background config is active Feb 9, 2022
@svengreb svengreb changed the base branch from develop to master May 14, 2022 12:48
@svengreb
Copy link
Member

svengreb commented Jun 21, 2023

@iysheng Thank (again!) you for your patience! 🙏🏼
It‘s been a while since I had free time to focus more on Nord, and my open source projects in general, and invest time in this issue due to work-life balance.

I recently published the first “Northern Post — The state and roadmap of Nord“ announcement which includes all details about the plans and future of the Nord project, including the goal of catching up with the backlog. This issue is part of the backlog and therefore I want to triage and process it to get one step closer to a “clean state“. Read the announcement about reaching the “clean“ contribution triage state in Nord‘s discussions for more details about the goal.

Therefore it has been added for triage in the central and single-source-of-truth project board that is also described in more detail in the roadmap announcement.


@iysheng Thanks again for your contribution 🚀
The pull request has been added for triage and the review will be planned for the next iterations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: triage
Development

Successfully merging this pull request may close these issues.

cursorline not highlighted
3 participants