Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Direct to 5.15] Handle empty initContainers array in postgres upgrade flow #1411

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

dannyzaken
Copy link
Contributor

@dannyzaken dannyzaken commented Aug 13, 2024

Explain the changes

  1. Adding the "missing" initContainer right before accessing podSpec.InitContainers array.
  2. In the previous fix, the init container was added to the DB reconcile, which happens after the upgrade flow.

Issues: Fixed #xxx / Gap #xxx

  1. https://bugzilla.redhat.com/show_bug.cgi?id=2281839

Testing Instructions:

  1. install noobaa 4.14
  2. stop the operator
  3. remove the init container from DB sts
  4. start the operator
  5. upgrade to 4.15
  6. before the fix, the operator would crash. after the fix, it should continue with the upgrade as expected
  • Doc added/updated
  • Tests added

@dannyzaken dannyzaken merged commit bb62937 into noobaa:5.15 Aug 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants