Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a fix to update bucketLogVolumes and bucketLogVolumeMounts in noobaa core pod #1406

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Added a fix to update bucketLogVolumes and bucketLogVolumeMounts in noobaa core pod #1406

merged 1 commit into from
Aug 7, 2024

Conversation

achouhan09
Copy link
Member

Explain the changes

  1. Currently, bucketLogVolumes and bucketLogVolumeMounts are not updating in noobaa core pod once set with bucketLogging. Added a fix to update both of them with bucketLogging.

Issues: Fixed #xxx / Gap #xxx

  1. fix: https://bugzilla.redhat.com/show_bug.cgi?id=2302842
  2. Improvement: Binding bucket logging pvc and path to core and endpoint pods #1371

Testing Instructions:

  1. Try updating bucketLoggingPVC in bucketLogging or removing bucketLogging and check if both volumes and volumeMounts got updated in noobaa core.

@achouhan09
Added a fix to update bucketLoggingPVC/bucketLoggingVolume and bucket…
97ad0da 
…LoggingVolumeMount in noobaa core pod

Signed-off-by: Aayush Chouhan <[email protected]>
@achouhan09 achouhan09 merged commit 3b212b5 into noobaa:master Aug 7, 2024
14 checks passed
@achouhan09 achouhan09 deleted the core-fix branch August 7, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackyalbo jackyalbo jackyalbo approved these changes

@aspandey aspandey Awaiting requested review from aspandey

@liranmauda liranmauda Awaiting requested review from liranmauda

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achouhan09 @jackyalbo