[Backport to 5.14] - operator-sdk removal and go 1.20 update #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
list of changes: Replaced operator-sdk command to generate 1. crds with controller-gen cmd 2. runtime object with deepcopy-gen 3. noobaa-operator and noobaa-operator-local directly with go build cmds 4. noobaa images with docker cmd Signed-off-by: Vinayakswami Hariharmath <[email protected]> (cherry picked from commit ed47d74)
Signed-off-by: Vinayakswami Hariharmath <[email protected]> (cherry picked from commit 4844d16)
update go version to 1.20 from 1,19 Signed-off-by: Vinayakswami Hariharmath <[email protected]> (cherry picked from commit 6a2855f)
nimrod-becker
approved these changes
Aug 8, 2023
liranmauda
approved these changes
Aug 8, 2023
vh05
reviewed
Aug 8, 2023
Signed-off-by: Vinayakswami Hariharmath <[email protected]> (cherry picked from commit 5bf67bf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: