Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove operator-sdk dependency #1151

Closed
wants to merge 1 commit into from
Closed

Remove operator-sdk dependency #1151

wants to merge 1 commit into from

Conversation

vh05
Copy link
Contributor

@vh05 vh05 commented Jul 4, 2023 •
edited
Loading 

Remove operator-sdk dependency

list of changes:
Replaced operator-sdk command to generate
1. crds with controller-gen cmd to align with go1.20
2. noobaa-operator and noobaa-operator-local directly with go build cmds
3. noobaa images with docker cmd

@vh05 vh05 marked this pull request as draft July 4, 2023 11:34
@vh05 vh05 requested a review from dannyzaken July 4, 2023 11:41
@vh05 vh05 force-pushed the remove-operator-sdk branch 2 times, most recently from dfb1790 to 9036ee8 Compare July 11, 2023 08:40
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jul 11, 2023
@vh05 vh05 force-pushed the remove-operator-sdk branch 2 times, most recently from 73ec9b5 to dcd2552 Compare July 11, 2023 12:42
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jul 11, 2023
@vh05 vh05 force-pushed the remove-operator-sdk branch 4 times, most recently from fc569d9 to 50f6a59 Compare July 12, 2023 12:38
@vh05 vh05 force-pushed the remove-operator-sdk branch 3 times, most recently from 0a22d30 to 612b3ca Compare July 26, 2023 08:23
@vh05 vh05 force-pushed the remove-operator-sdk branch 4 times, most recently from ba8199e to 3544679 Compare July 27, 2023 10:30
@vh05 @vharihar2
Remove operator-sdk dependency
59ffd74 
list of changes:
Replaced operator-sdk command to generate
1. crds with controller-gen cmd to align with go1.20
2. runtime object with deepcopy-gen
3. noobaa-operator and noobaa-operator-local directly with go build cmds
4. noobaa images with docker cmd

Signed-off-by: Vinayakswami Hariharmath <[email protected]>
@vh05 vh05 closed this Jul 31, 2023
@vh05 vh05 deleted the remove-operator-sdk branch July 31, 2023 05:58
@vh05 vh05 restored the remove-operator-sdk branch July 31, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannyzaken dannyzaken Awaiting requested review from dannyzaken

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vh05