Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc | Deploy Noobaa On Minikube or Rancher Desktop (For Developers) #1097

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Doc | Deploy Noobaa On Minikube or Rancher Desktop (For Developers) #1097

merged 1 commit into from
Jul 31, 2023

Conversation

shirady
Copy link
Contributor

@shirady shirady commented Apr 20, 2023 •
edited
Loading

Explain the changes

  1. Add guide deploy noobaa on minikube or Rancher Desktop (for developers).

Issues: Fixed #xxx / Gap #xxx

  1. Gap - update documentation:

Testing Instructions:

  1. none.

Notes:

This PR was originally opened in noobaa-core repository noobaa/noobaa-core#7261

  • Doc added/updated
  • Tests added

@shirady shirady self-assigned this Apr 20, 2023
@shirady shirady marked this pull request as draft May 2, 2023 11:57
@shirady shirady mentioned this pull request Jun 18, 2023
Merged
2 tasks
@shirady shirady requested a review from naveenpaul1 July 30, 2023 07:13
@shirady shirady marked this pull request as ready for review July 30, 2023 07:14
naveenpaul1
naveenpaul1 reviewed Jul 31, 2023
View reviewed changes
doc/dev_guide/deply_noobaa_on_local_machine.md Outdated Show resolved Hide resolved
doc/dev_guide/deply_noobaa_on_local_machine.md Outdated Show resolved Hide resolved
doc/dev_guide/deply_noobaa_on_local_machine.md Outdated Show resolved Hide resolved
doc/dev_guide/deply_noobaa_on_local_machine.md Outdated Show resolved Hide resolved
@shirady shirady requested a review from naveenpaul1 July 31, 2023 09:22
naveenpaul1
naveenpaul1 approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@naveenpaul1 naveenpaul1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirady shirady changed the title Add Deploy Noobaa On Minikube Documentation (For Developers) Add Deploy Noobaa On Minikube or Rancher Desktop Documentation (For Developers) Jul 31, 2023
@shirady shirady merged commit 54efc35 into noobaa:master Jul 31, 2023
14 checks passed
@shirady shirady deleted the doc-deploy-on-minikube branch August 1, 2023 06:50
@shirady shirady changed the title Add Deploy Noobaa On Minikube or Rancher Desktop Documentation (For Developers) Doc | Deploy Noobaa On Minikube or Rancher Desktop (For Developers) Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naveenpaul1 naveenpaul1 naveenpaul1 approved these changes

@liranmauda liranmauda Awaiting requested review from liranmauda

@dannyzaken dannyzaken Awaiting requested review from dannyzaken

@Neon-White Neon-White Awaiting requested review from Neon-White

Assignees

@shirady shirady

Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shirady @naveenpaul1