Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NC | Online Upgrade | Health CLI update config directory and upgrade checks #8532

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

romayalon
Copy link
Contributor

@romayalon romayalon commented Nov 14, 2024

Explain the changes

  1. Added a check in the Health CLI that shows the config directory status if exists.
  2. Added a check in the Health CLI that asserts if the upgrade of the config directory has issues, this situation can be discovered by phase of the config directory is locked and there is no ongoing upgrade.
  3. Added unit tests (and did some refactoring).
  4. Fixed a bug that sets the process name to be Upgrade, it's showing in the logs of the endpoint, CLI etc.

Issues: Fixed #xxx / Gap #xxx

  1. Another idea for a health check - check per host if config directory is locked.

Testing Instructions:

  1. sudo node ./node_modules/mocha/bin/mocha src/test/unit_tests/test_nc_health.js
  • Doc added/updated
  • Tests added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant