-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NSFS | Versioning | Delete of partial directory of nested key results in AccessDeniedError #8480
Conversation
53771ce
to
416f4d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added minor comments
@naveenpaul1 could you add the test in file |
0c93d80
to
9b76008
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
added 2 minor comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to request changes because the original issue seems incorrect to me, can you please check that throwing AccessDenied is also not thrown by AWS in the specified reproduction steps?
@romayalon added the AWS same behaviour finding in issue , For AWS aslo partial dir key is creating delete_marker for object. |
@naveenpaul1 thanks for checking it, |
@romayalon updated the get-object behavior in issue please check |
3cb4412
to
1a11e80
Compare
1a11e80
to
3ca7703
Compare
3ca7703
to
0e4df2a
Compare
0e4df2a
to
8f5ba0c
Compare
… in AccessDeniedError Signed-off-by: naveenpaul1 <[email protected]>
8f5ba0c
to
1625468
Compare
Explain the changes
a/b/c/
) just deletes the .folder file and does not create delete_marker.a/b/c/test.txt
and then tries to delete keya/b/c
code will throwAccessDenied
error.Issues: Fixed #xxx / Gap #xxx
AccessDeniedError
#8454Testing Instructions: