Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release query #490

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Release query #490

merged 3 commits into from
Jan 30, 2025

Conversation

gmanev7
Copy link
Member

@gmanev7 gmanev7 commented Jan 29, 2025

No description provided.

@gmanev7 gmanev7 requested a review from KirilMihaylov January 29, 2025 13:03
KirilMihaylov
KirilMihaylov requested changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@KirilMihaylov KirilMihaylov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment about minor refactoring in the platform/versioning/release/query module and one concern about changing the API.

Otherwise, LGTM.

platform/packages/versioning/src/release/query.rs Show resolved Hide resolved
protocol/contracts/lease/src/api/query.rs Show resolved Hide resolved
@gmanev7 gmanev7 merged commit 0edd2dd into main Jan 30, 2025
96 checks passed
@gmanev7 gmanev7 deleted the release-query branch January 30, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KirilMihaylov KirilMihaylov KirilMihaylov requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gmanev7 @KirilMihaylov