feat: improve testing of http2 #3719
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems CI is failing |
|
I am still checking if this makes any sense. maybe a proxyquire would be more useful instead of using this approach. |
|
I think we should just skip a bunch of tests if ssl is not available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am too lazy to build with without-ssl flag locally. I think the values we destructure when importing http2 are not critical. more critical is, that http2.connect is not replaced with some function which throws an Internal Error which would indicate that http2 is not supported. Probably we get only a "connect is not defined" error. when calling it.