inspector: add Network.Initiator in inspector protocol #56805
+95
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add initiator stack trace in inspector network events, reflecting the location where the script created the request. The `http.client.request.created` event is closer to where user code creates the http request, and correctly reflects which script initiated the request.
|
Review requested:
|
nodejs-github-bot
added
c++
legendecas
added
inspector
jasnell
approved these changes
Jan 28, 2025
anonrig
reviewed
Jan 28, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56805 +/- ##
==========================================
- Coverage 89.22% 89.22% -0.01%
==========================================
Files 663 663
Lines 191974 191981 +7
Branches 36916 36923 +7
==========================================
+ Hits 171286 171287 +1
- Misses 13558 13559 +1
- Partials 7130 7135 +5
|
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
|
The CI failure on SmartOS seems related to the change, will take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initiator stack trace in inspector network events, reflecting
the location where the script created the request.
The
http.client.request.createdevent is closer to where user codecreates the http request, and correctly reflects which script
initiated the request.
Refs: #53946