Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: reduce number of written chunks #56757

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: reduce number of written chunks #56757

wants to merge 1 commit into from
+35 −25

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Jan 25, 2025

Reduce chances of write errors while the request is sent.

Refs: #56756

@lpinca
test: reduce number of written chunks
8a865db 
Reduce chances of write errors while the request is sent.

Refs: nodejs#56756
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 25, 2025
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 25, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 25, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64740/

@codecov Codecov
Copy link

codecov bot commented Jan 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.22%. Comparing base (1760024) to head (8a865db).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56757      +/-   ##
==========================================
+ Coverage   89.20%   89.22%   +0.01%     
==========================================
  Files         662      662              
  Lines      192124   192124              
  Branches    36972    36978       +6     
==========================================
+ Hits       171390   171415      +25     
+ Misses      13559    13549      -10     
+ Partials     7175     7160      -15

see 23 files with indirect coverage changes

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64746/

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lpinca @nodejs-github-bot @jasnell @aduh95