Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix styles of the expandable TOC #56755

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 24, 2025

The current CSS uses ::before to build custom list markers, which causes them to appear underlined. This PR undoes that to use plain old list marker instead.

Before

screenshot of the expanded Table of Contents from the current website

After

screenshot of the expanded Table of Contents from this PR

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/nodejs-website

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 24, 2025
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 24, 2025
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 25, 2025
@ovflowd
Copy link
Member

ovflowd commented Jan 26, 2025

@aduh95 would you mind backporting these to the api-docs-tooling repo? Otherwise I can do'em!

@ovflowd
Copy link
Member

ovflowd commented Jan 26, 2025

nvm, making a PR myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants