Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve accessibility of expandable lists #56749

Merged
merged 5 commits into from
Jan 26, 2025
Merged

doc: improve accessibility of expandable lists #56749

merged 5 commits into from
Jan 26, 2025

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 24, 2025 •
edited
Loading

  • Focus the first link in the expandable list – currently the focus stays on the opening link, which can be confusing for folks using a screen reader (if you don't have a visual clue, you don't know if the clicking link did anything).
  • Remove focusability on the wrapping div – I don't think focusing it any purpose, so let's remove that additional keyboard and screen reader users have to make.
  • Fix the keyboard navigation when JS is disabled.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/nodejs-website
  • @nodejs/web-infra

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Jan 24, 2025
@aduh95 aduh95 added lts-watch-v18.x PRs that may need to be released in v18.x. lts-watch-v20.x PRs that may need to be released in v20.x lts-watch-v22.x PRs that may need to be released in v22.x labels Jan 24, 2025
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jan 24, 2025
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 25, 2025
@ovflowd ovflowd mentioned this pull request Jan 26, 2025
Open
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 26, 2025
@nodejs-github-bot nodejs-github-bot merged commit a6c5ce2 into nodejs:main Jan 26, 2025
31 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a6c5ce2

@aduh95 aduh95 deleted the accessibility-expandables branch January 26, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

@ovflowd ovflowd ovflowd approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. lts-watch-v18.x PRs that may need to be released in v18.x. lts-watch-v20.x PRs that may need to be released in v20.x lts-watch-v22.x PRs that may need to be released in v22.x tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aduh95 @nodejs-github-bot @jasnell @UlisesGascon @ovflowd @AugustinMauroy