test: make some requires lazy in common/index #56715
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
anonrig
approved these changes
Jan 23, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56715 +/- ##
=======================================
Coverage 89.21% 89.21%
=======================================
Files 662 662
Lines 192124 192124
Branches 36980 36975 -5
=======================================
+ Hits 171404 171409 +5
+ Misses 13552 13548 -4
+ Partials 7168 7167 -1 |
This comment was marked as outdated.
This comment was marked as outdated.
richardlau
approved these changes
Jan 23, 2025
jasnell
added
the
author ready
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/56715 ✔ Done loading data for nodejs/node/pull/56715 ----------------------------------- PR info ------------------------------------ Title test: make some requires lazy in common/index (#56715) Author James M Snell <[email protected]> (@jasnell) Branch jasnell:jasnell/test-lazy-requires -> nodejs:main Labels test, author ready Commits 1 - test: make some requires lazy in common/index Committers 1 - James M Snell <[email protected]> PR-URL: https://github.com/nodejs/node/pull/56715 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Richard Lau <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/56715 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Richard Lau <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 23 Jan 2025 01:00:29 GMT ✔ Approvals: 2 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/56715#pullrequestreview-2568641434 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/56715#pullrequestreview-2570142106 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-01-23T22:59:14Z: https://ci.nodejs.org/job/node-test-pull-request/64676/ - Querying data for job/node-test-pull-request/64676/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 56715 From https://github.com/nodejs/node * branch refs/pull/56715/merge -> FETCH_HEAD ✔ Fetched commits as c752615e2bbe..dfea11db9157 -------------------------------------------------------------------------------- Auto-merging test/common/index.js CONFLICT (content): Merge conflict in test/common/index.js error: could not apply dfea11db91... test: make some requires lazy in common/index hint: After resolving the conflicts, mark them with hint: "git add/rm <pathspec>", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort". hint: Disable this message with "git config set advice.mergeConflict false" ✘ Failed to apply patcheshttps://github.com/nodejs/node/actions/runs/12960548139 |
jasnell
force-pushed
the
jasnell/test-lazy-requires
branch
from
dfea11d to
47b9729
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
removed
the
commit-queue-failed
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
approved these changes
Jan 25, 2025
jasnell
added a commit
that referenced
this pull request
Jan 25, 2025
PR-URL: #56715 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
|
Landed in 23d0a7f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lazily require
child_processandisModuleNamespaceObjectonly when actually needed.