Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: add check for Bignum in GroupOrderSize #56702

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

src: add check for Bignum in GroupOrderSize #56702

wants to merge 1 commit into from
+1 −0

Conversation

wooffie
Copy link

@wooffie wooffie commented Jan 22, 2025 •
edited by aduh95
Loading

I think it's missed, cause in this file we have example of checking result of BignumPointer::new

Fixes: #56692

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Jan 22, 2025
@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64661/

@codecov Codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.21%. Comparing base (08eeddf) to head (ab67bb9).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
src/crypto/crypto_ec.cc 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56702      +/-   ##
==========================================
- Coverage   89.21%   89.21%   -0.01%     
==========================================
  Files         662      662              
  Lines      191968   191969       +1     
  Branches    36955    36955              
==========================================
- Hits       171269   171261       -8     
- Misses      13535    13550      +15     
+ Partials     7164     7158       -6
Files with missing lines Coverage Δ
src/crypto/crypto_ec.cc 66.66% <0.00%> (+0.75%) ⬆️

... and 38 files with indirect coverage changes

@lpinca
Copy link
Member

lpinca commented Jan 24, 2025

This needs a rebase to fix test failures.

@lpinca
Copy link
Member

lpinca commented Jan 24, 2025

@wooffie please remove the merge commits, rebase and force push, thank you.

src: add check for Bignum in GroupOrderSize
ab67bb9 
I think it's missed, cause in this file we have example of checking
result of BignumPointer::new

Refs: nodejs#56692
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 24, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 24, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64735/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lack of nullptr check in src/crypto/crypto_ec.cc GroupOrderSize
4 participants
@wooffie @nodejs-github-bot @lpinca @jasnell