Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: macro ENODATA is deprecated in libc++ #56698

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Jan 22, 2025

The ENODATA macro, which is used by uv's public headererrno.h, has been deprecated in libc++.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run. labels Jan 22, 2025
@anonrig
Copy link
Member

anonrig commented Jan 22, 2025

Cc @nodejs/libuv

@legendecas
Copy link
Member

This needs a rebase to fix the test failures.

@zcbenz zcbenz added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2025
@nodejs-github-bot
Copy link
Collaborator

@zcbenz zcbenz changed the title deps: ENODATA is deprecated in libc++ deps: macro ENODATA is deprecated in libc++ Jan 23, 2025
@zcbenz zcbenz added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 24, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 24, 2025
@nodejs-github-bot
Copy link
Collaborator

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 26, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 26, 2025
@nodejs-github-bot nodejs-github-bot merged commit e1e1ada into nodejs:main Jan 26, 2025
58 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in e1e1ada

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants