-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
module: add dynamic file-specific ESM warnings #56628
Open
mertcanaltin
wants to merge
5
commits into
nodejs:main
Choose a base branch
from
mertcanaltin:mert/improve-esm-warning
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+69
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
vm
Issues and PRs related to the vm subsystem.
labels
Jan 16, 2025
mertcanaltin
force-pushed
the
mert/improve-esm-warning
branch
from
January 16, 2025 15:17
621136c
to
777a249
Compare
mertcanaltin
added
module
Issues and PRs related to the module subsystem.
esm
Issues and PRs related to the ECMAScript Modules implementation.
labels
Jan 16, 2025
mertcanaltin
changed the title
feat: add dynamic file-specific ESM warnings
module: add dynamic file-specific ESM warnings
Jan 16, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56628 +/- ##
==========================================
+ Coverage 89.19% 89.21% +0.01%
==========================================
Files 662 662
Lines 191893 191976 +83
Branches 36937 36948 +11
==========================================
+ Hits 171164 171272 +108
+ Misses 13573 13549 -24
+ Partials 7156 7155 -1
|
Could this be flakky? but tests to my local is success https://github.com/nodejs/node/actions/runs/12811945783/job/35722483892?pr=56628 |
addaleax
reviewed
Jan 19, 2025
Co-authored-by: Anna Henningsen <[email protected]>
legendecas
reviewed
Jan 23, 2025
Co-authored-by: Antoine du Hamel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I improved the error message to include specific file and package.json details, trying to make it clearer and more actionable as requested in the TODO