-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util: rename CallSite.column to columnNumber #56584
util: rename CallSite.column to columnNumber #56584
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could already add a doc only deprecation in this PR. Otherwise LGTM
Align the property names `lineNumber` and `columnNumber`.
edb6b7f
to
40a94ec
Compare
@BridgeAR in the change section, a deprecation note "Property Line 3130 in db7a31e
Line 3133 in db7a31e
|
We just need to assign a new deprecation number and document it in the specific deprecation section: https://github.com/nodejs/node/blob/main/doc/api/deprecations.md |
This API is still "Stability: 1.1 - Active development". Deprecations in experimental APIs do not necesirily need a deprecation code through the deprecation cycle: https://github.com/nodejs/node/blob/main/doc/api/documentation.md#stability-index |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56584 +/- ##
==========================================
- Coverage 89.19% 89.19% -0.01%
==========================================
Files 662 662
Lines 191794 191797 +3
Branches 36927 36919 -8
==========================================
+ Hits 171076 171078 +2
+ Misses 13568 13565 -3
- Partials 7150 7154 +4
|
Landed in 1238f0a |
Align the property names
lineNumber
andcolumnNumber
.The name should either be
line
andcolumn
, orlineNumber
andcolumnNumber
, but not mixing up. This leads confusing doc likenode/lib/util.js
Lines 337 to 344 in db7a31e