-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util: inspect: do not crash on an Error with a regex name
#56574
base: main
Are you sure you want to change the base?
Conversation
1f2a8f0
to
d33853a
Compare
name
name
name
name
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56574 +/- ##
=======================================
Coverage 89.20% 89.20%
=======================================
Files 662 662
Lines 191817 191828 +11
Branches 36922 36928 +6
=======================================
+ Hits 171101 171113 +12
- Misses 13556 13561 +5
+ Partials 7160 7154 -6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could improve the result by logging even more information. It just requires a bit more code changes.
0fcb903
to
d842336
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I very much like the improved output!
It might be possible to unify some paths in the improveStack()
method, while that's not critical in my opinion.
This needs a rebase |
d842336
to
73c0e96
Compare
73c0e96
to
a9638dc
Compare
See #56570 - this avoids a crash with a regex set as the
name
property of an Error