-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util: inspect: do not crash on Symbol function names #56572
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56572 +/- ##
==========================================
- Coverage 89.20% 89.20% -0.01%
==========================================
Files 662 662
Lines 191794 191794
Branches 36915 36921 +6
==========================================
- Hits 171084 171083 -1
+ Misses 13564 13562 -2
- Partials 7146 7149 +3
|
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not call inspect()
from inside a inspect call. Otherwise the indentation is potentially off.
6932162
to
cda0416
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@ljharb Please do not add the label when no commits were pushed since previous CI node/doc/contributing/collaborator-guide.md Lines 252 to 261 in 5747828
|
This comment was marked as outdated.
This comment was marked as outdated.
ah ok, thanks |
Landed in 2570f95 |
See #56570 - this avoids a crash when a Function name is a Symbol.