Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update amaro to 0.3.0 #56568

Closed
wants to merge 4 commits into from
Closed

deps: update amaro to 0.3.0 #56568

wants to merge 4 commits into from
+314 −301

Conversation

nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Jan 12, 2025 •
edited
Loading

This is an automated update of amaro to 0.3.0.

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. strip-types Issues or PRs related to strip-types support labels Jan 12, 2025
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/security-wg
  • @nodejs/typescript

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jan 12, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.19%. Comparing base (808e6b3) to head (699348b).
Report is 36 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56568      +/-   ##
==========================================
+ Coverage   89.18%   89.19%   +0.01%     
==========================================
  Files         662      662              
  Lines      191759   191825      +66     
  Branches    36911    36917       +6     
==========================================
+ Hits       171017   171101      +84     
+ Misses      13613    13574      -39     
- Partials     7129     7150      +21
Files with missing lines Coverage Δ
lib/internal/modules/typescript.js 100.00% <100.00%> (ø)

... and 33 files with indirect coverage changes

@marco-ippolito
Copy link
Member

marco-ippolito commented Jan 13, 2025 •
edited
Loading

This requires to update snapshots because swc has removed the caused by in the message

@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/64487/

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/64495/

@marco-ippolito
Copy link
Member

mhhh CI is green https://ci.nodejs.org/job/node-test-pull-request/64495/
idk why it shows as still running

@nodejs-github-bot nodejs-github-bot changed the title deps: update amaro to 0.2.2 deps: update amaro to 0.3.0 Jan 14, 2025
@marco-ippolito marco-ippolito added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 14, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 14, 2025
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/64505/

@marco-ippolito
Copy link
Member

breaking change from amaro v0.3.0, now swc is able to check if its a syntax error or invalid syntax so it requires to update the code a little bit

@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 14, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 14, 2025
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/64512/

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/64517/

@marco-ippolito marco-ippolito added commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 15, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 15, 2025
@nodejs-github-bot
Copy link
Collaborator Author

Landed in f16cd10...e799ebd

nodejs-github-bot added a commit that referenced this pull request Jan 15, 2025
@nodejs-github-bot
deps: update amaro to 0.2.2
dd26064 
PR-URL: #56568
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Jan 15, 2025
@marco-ippolito @nodejs-github-bot
test: update ts eval snapshots
e52440b 
PR-URL: #56568
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
nodejs-github-bot added a commit that referenced this pull request Jan 15, 2025
@nodejs-github-bot
deps: update amaro to 0.3.0
d1a3f30 
PR-URL: #56568
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Jan 15, 2025
@marco-ippolito @nodejs-github-bot
module: rethrow amaro error message
e799ebd 
PR-URL: #56568
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmarchini pmarchini pmarchini approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

@ShogunPanda ShogunPanda ShogunPanda approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. strip-types Issues or PRs related to strip-types support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nodejs-github-bot @marco-ippolito @ShogunPanda @JakobJingleheimer @RafaelGSS @pmarchini