src: cleaning up more crypto internals for ncrypto #56526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
lib / src
anonrig
approved these changes
Jan 9, 2025
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
jasnell/moar-ncrypto-cleanup
branch
from
15fd9fa to
48cab6e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
added
author ready
anonrig
approved these changes
Jan 9, 2025
|
@nodejs/collaborators ... would appreciate more review here if possible. |
|
Code changes look good to me, but I don't trust myself to review a C++ change this large. We do have a @nodejs/cpp-reviewers team though. Maybe someone on that team can take a look. |
|
This is an absurdly minuscule nit, and feel free to ignore, but perhaps just a reminder for the future: Our contributing guide says to make the first word of the commit title after the colon an imperative verb. So it should be "clean up more..." rather than "cleaning up more...." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.