Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: correct customization hook types & clarify descriptions #56454

Merged
merged 3 commits into from
Jan 14, 2025
Merged

doc: correct customization hook types & clarify descriptions #56454

merged 3 commits into from
Jan 14, 2025

Conversation

JakobJingleheimer
Copy link
Member

No description provided.

@JakobJingleheimer JakobJingleheimer added doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. loaders Issues and PRs related to ES module loaders labels Jan 3, 2025
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. labels Jan 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Fast-track has been requested by @JakobJingleheimer. Please 👍 to approve.

@JakobJingleheimer JakobJingleheimer mentioned this pull request Jan 3, 2025
Open
7 tasks
@codecov Codecov
Copy link

codecov bot commented Jan 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.20%. Comparing base (19d58c5) to head (06bd263).
Report is 84 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56454      +/-   ##
==========================================
+ Coverage   88.53%   89.20%   +0.66%     
==========================================
  Files         657      662       +5     
  Lines      190724   191817    +1093     
  Branches    36600    36920     +320     
==========================================
+ Hits       168867   171102    +2235     
+ Misses      15031    13561    -1470     
- Partials     6826     7154     +328
Files with missing lines Coverage Δ
lib/internal/modules/customization_hooks.js 100.00% <100.00%> (ø)

... and 135 files with indirect coverage changes

jasnell
jasnell reviewed Jan 3, 2025
View reviewed changes
doc/api/module.md Outdated Show resolved Hide resolved
GeoffreyBooth
GeoffreyBooth approved these changes Jan 4, 2025
View reviewed changes
doc/api/module.md Outdated Show resolved Hide resolved
@JakobJingleheimer JakobJingleheimer mentioned this pull request Jan 7, 2025
Merged
AugustinMauroy
AugustinMauroy approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@JakobJingleheimer JakobJingleheimer added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64474/

jsumners-nr
jsumners-nr approved these changes Jan 13, 2025
View reviewed changes
Copy link

@jsumners-nr jsumners-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64482/

mcollina
mcollina approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JakobJingleheimer JakobJingleheimer added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed needs-ci PRs that need a full CI run. labels Jan 14, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 14, 2025
@nodejs-github-bot nodejs-github-bot merged commit fc11189 into nodejs:main Jan 14, 2025
65 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in fc11189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Renegade334 Renegade334 Renegade334 left review comments

@jsumners-nr jsumners-nr jsumners-nr approved these changes

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. loaders Issues and PRs related to ES module loaders module Issues and PRs related to the module subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@JakobJingleheimer @nodejs-github-bot @mcollina @jasnell @GeoffreyBooth @Renegade334 @AugustinMauroy @jsumners-nr