test: replace more uses of global with globalThis

PR-URL: #56712 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
nodejs · Jan 25, 2025 · 97a3a82 · 97a3a82
1 parent 552362a
commit 97a3a82
Show file tree

Hide file tree

Showing 74 changed files with 246 additions and 242 deletions.
diff --git a/test/parallel/test-aborted-util.js b/test/parallel/test-aborted-util.js
@@ -32,7 +32,7 @@ test('Aborted with gc cleanup', async () => {
   const { promise, resolve } = Promise.withResolvers();
 
   setImmediate(() => {
-    global.gc();
+    globalThis.gc();
     ac.abort();
     strictEqual(ac.signal.aborted, true);
     strictEqual(getEventListeners(ac.signal, 'abort').length, 0);

diff --git a/test/parallel/test-abortsignal-drop-settled-signals.mjs b/test/parallel/test-abortsignal-drop-settled-signals.mjs
@@ -16,7 +16,7 @@ function makeSubsequentCalls(limit, done, holdReferences = false) {
       // This setImmediate is necessary to ensure that in the last iteration the remaining signal is GCed (if not
       // retained)
       setImmediate(() => {
-        global.gc();
+        globalThis.gc();
         done(ac.signal, dependantSymbol);
       });
       return;
@@ -50,7 +50,7 @@ function runShortLivedSourceSignal(limit, done) {
 
   function run(iteration) {
     if (iteration > limit) {
-      global.gc();
+      globalThis.gc();
       done(signalRefs);
       return;
     }
@@ -74,9 +74,9 @@ function runWithOrphanListeners(limit, done) {
     const ac = new AbortController();
     if (iteration > limit) {
       setImmediate(() => {
-        global.gc();
+        globalThis.gc();
         setImmediate(() => {
-          global.gc();
+          globalThis.gc();
 
           done(composedSignalRefs);
         });
@@ -147,7 +147,7 @@ it('drops settled dependant signals when signal is composite', (t, done) => {
   t.assert.strictEqual(controllers[1].signal[kDependantSignals].size, 1);
 
   setImmediate(() => {
-    global.gc({ execution: 'async' }).then(async () => {
+    globalThis.gc({ execution: 'async' }).then(async () => {
       await gcUntil('all signals are GCed', () => {
         const totalDependantSignals = Math.max(
           controllers[0].signal[kDependantSignals].size,

diff --git a/test/parallel/test-assert-checktag.js b/test/parallel/test-assert-checktag.js
@@ -49,13 +49,13 @@ test('', { skip: !hasCrypto }, () => {
 
   {  // At the moment global has its own type tag
     const fakeGlobal = {};
-    Object.setPrototypeOf(fakeGlobal, Object.getPrototypeOf(global));
-    for (const prop of Object.keys(global)) {
+    Object.setPrototypeOf(fakeGlobal, Object.getPrototypeOf(globalThis));
+    for (const prop of Object.keys(globalThis)) {
       fakeGlobal[prop] = global[prop];
     }
-    assert.notDeepEqual(fakeGlobal, global);
+    assert.notDeepEqual(fakeGlobal, globalThis);
     // Message will be truncated anyway, don't validate
-    assert.throws(() => assert.deepStrictEqual(fakeGlobal, global),
+    assert.throws(() => assert.deepStrictEqual(fakeGlobal, globalThis),
                   assert.AssertionError);
   }
 

diff --git a/test/parallel/test-async-hooks-destroy-on-gc.js b/test/parallel/test-async-hooks-destroy-on-gc.js
@@ -22,6 +22,6 @@ let asyncId = null;
 }
 
 setImmediate(() => {
-  global.gc();
+  globalThis.gc();
   setImmediate(() => assert.ok(destroyedIds.has(asyncId)));
 });
diff --git a/test/parallel/test-async-hooks-disable-gc-tracking.js b/test/parallel/test-async-hooks-disable-gc-tracking.js
@@ -14,7 +14,7 @@ const hook = async_hooks.createHook({
 new async_hooks.AsyncResource('foobar', { requireManualDestroy: true });
 
 setImmediate(() => {
-  global.gc();
+  globalThis.gc();
   setImmediate(() => {
     hook.disable();
   });

diff --git a/test/parallel/test-async-hooks-prevent-double-destroy.js b/test/parallel/test-async-hooks-prevent-double-destroy.js
@@ -17,7 +17,7 @@ const hook = async_hooks.createHook({
 }
 
 setImmediate(() => {
-  global.gc();
+  globalThis.gc();
   setImmediate(() => {
     hook.disable();
   });

diff --git a/test/parallel/test-cli-eval.js b/test/parallel/test-cli-eval.js
@@ -345,7 +345,7 @@ child.exec(
 // Regression test for https://github.com/nodejs/node/issues/45336
 child.execFile(process.execPath,
                ['-p',
-                'Object.defineProperty(global, "fs", { configurable: false });' +
+                'Object.defineProperty(globalThis, "fs", { configurable: false });' +
                 'fs === require("node:fs")'],
                common.mustSucceed((stdout) => {
                  assert.match(stdout, /^true/);

diff --git a/test/parallel/test-common-gc.js b/test/parallel/test-common-gc.js
@@ -5,10 +5,10 @@ const { onGC } = require('../common/gc');
 
 {
   onGC({}, { ongc: common.mustCall() });
-  global.gc();
+  globalThis.gc();
 }
 
 {
   onGC(process, { ongc: common.mustNotCall() });
-  global.gc();
+  globalThis.gc();
 }
diff --git a/test/parallel/test-console-assign-undefined.js b/test/parallel/test-console-assign-undefined.js
@@ -1,28 +1,28 @@
 'use strict';
 
-// Patch global.console before importing modules that may modify the console
+// Patch globalThis.console before importing modules that may modify the console
 // object.
 
-const tmp = global.console;
-global.console = 42;
+const tmp = globalThis.console;
+globalThis.console = 42;
 
 require('../common');
 const assert = require('assert');
 
 // Originally the console had a getter. Test twice to verify it had no side
 // effect.
-assert.strictEqual(global.console, 42);
-assert.strictEqual(global.console, 42);
+assert.strictEqual(globalThis.console, 42);
+assert.strictEqual(globalThis.console, 42);
 
 assert.throws(
   () => console.log('foo'),
   { name: 'TypeError' }
 );
 
-global.console = 1;
-assert.strictEqual(global.console, 1);
+globalThis.console = 1;
+assert.strictEqual(globalThis.console, 1);
 assert.strictEqual(console, 1);
 
 // Reset the console
-global.console = tmp;
+globalThis.console = tmp;
 console.log('foo');
diff --git a/test/parallel/test-console-instance.js b/test/parallel/test-console-instance.js
@@ -36,9 +36,9 @@ process.stdout.write = process.stderr.write = common.mustNotCall();
 // Make sure that the "Console" function exists.
 assert.strictEqual(typeof Console, 'function');
 
-assert.strictEqual(requiredConsole, global.console);
+assert.strictEqual(requiredConsole, globalThis.console);
 // Make sure the custom instanceof of Console works
-assert.ok(global.console instanceof Console);
+assert.ok(globalThis.console instanceof Console);
 assert.ok(!({} instanceof Console));
 
 // Make sure that the Console constructor throws

diff --git a/test/parallel/test-console-self-assign.js b/test/parallel/test-console-self-assign.js
@@ -3,4 +3,4 @@
 require('../common');
 
 // Assigning to itself should not throw.
-global.console = global.console; // eslint-disable-line no-self-assign
+globalThis.console = globalThis.console; // eslint-disable-line no-self-assign
diff --git a/test/parallel/test-crypto-dh-leak.js b/test/parallel/test-crypto-dh-leak.js
@@ -22,7 +22,7 @@ const before = process.memoryUsage.rss();
     dh.setPrivateKey(privateKey);
   }
 }
-global.gc();
+globalThis.gc();
 const after = process.memoryUsage.rss();
 
 // RSS should stay the same, ceteris paribus, but allow for

diff --git a/test/parallel/test-domain-crypto.js b/test/parallel/test-domain-crypto.js
@@ -31,7 +31,7 @@ const crypto = require('crypto');
 // Pollution of global is intentional as part of test.
 common.allowGlobals(require('domain'));
 // See https://github.com/nodejs/node/commit/d1eff9ab
-global.domain = require('domain');
+globalThis.domain = require('domain');
 
 // Should not throw a 'TypeError: undefined is not a function' exception
 crypto.randomBytes(8);

diff --git a/test/parallel/test-eventtarget-memoryleakwarning.js b/test/parallel/test-eventtarget-memoryleakwarning.js
@@ -103,7 +103,7 @@ common.expectWarning({
       });
 
       await setTimeout(0);
-      global.gc();
+      globalThis.gc();
     }
   })().then(common.mustCall(), common.mustNotCall());
 }
diff --git a/test/parallel/test-eventtarget.js b/test/parallel/test-eventtarget.js
@@ -683,7 +683,7 @@ let asyncTest = Promise.resolve();
   const et = new EventTarget();
   et.addEventListener('foo', common.mustNotCall(), { [kWeakHandler]: {} });
   setImmediate(() => {
-    global.gc();
+    globalThis.gc();
     et.dispatchEvent(new Event('foo'));
   });
 }

diff --git a/test/parallel/test-finalization-registry-shutdown.js b/test/parallel/test-finalization-registry-shutdown.js
@@ -19,5 +19,5 @@ process.on('exit', () => {
   // This is the final chance to execute JavaScript.
   register();
   // Queue a FinalizationRegistryCleanupTask by a testing gc request.
-  global.gc();
+  globalThis.gc();
 });
diff --git a/test/parallel/test-fs-filehandle.js b/test/parallel/test-fs-filehandle.js
@@ -35,6 +35,6 @@ common.expectWarning({
   'DeprecationWarning': [[deprecationWarning, 'DEP0137']]
 });
 
-global.gc();
+globalThis.gc();
 
 setTimeout(() => {}, 10);
diff --git a/test/parallel/test-fs-promises-file-handle-close.js b/test/parallel/test-fs-promises-file-handle-close.js
@@ -32,7 +32,7 @@ doOpen().then(common.mustCall((fd) => {
 })).then(common.mustCall(() => {
   setImmediate(() => {
     // The FileHandle should be out-of-scope and no longer accessed now.
-    global.gc();
+    globalThis.gc();
 
     // Wait an extra event loop turn, as the warning is emitted from the
     // native layer in an unref()'ed setImmediate() callback.

diff --git a/test/parallel/test-fs-write-reuse-callback.js b/test/parallel/test-fs-write-reuse-callback.js
@@ -20,7 +20,7 @@ let done = 0;
 
 const ondone = common.mustSucceed(() => {
   if (++done < writes) {
-    if (done % 25 === 0) global.gc();
+    if (done % 25 === 0) globalThis.gc();
     setImmediate(write);
   } else {
     assert.strictEqual(

diff --git a/test/parallel/test-fs-write.js b/test/parallel/test-fs-write.js
@@ -39,14 +39,18 @@ const {
   createExternalizableString,
   externalizeString,
   isOneByteString,
-} = global;
+} = globalThis;
+
+assert.notStrictEqual(createExternalizableString, undefined);
+assert.notStrictEqual(externalizeString, undefined);
+assert.notStrictEqual(isOneByteString, undefined);
 
 // Account for extra globals exposed by --expose_externalize_string.
 common.allowGlobals(
   createExternalizableString,
   externalizeString,
   isOneByteString,
-  global.x,
+  globalThis.x,
 );
 
 {

diff --git a/test/parallel/test-gc-http-client-connaborted.js b/test/parallel/test-gc-http-client-connaborted.js
@@ -53,7 +53,7 @@ setImmediate(status);
 function status() {
   if (done > 0) {
     createClients = false;
-    global.gc();
+    globalThis.gc();
     console.log(`done/collected/total: ${done}/${countGC}/${count}`);
     if (countGC === count) {
       server.close();

diff --git a/test/parallel/test-gc-net-timeout.js b/test/parallel/test-gc-net-timeout.js
@@ -64,7 +64,7 @@ setImmediate(status);
 function status() {
   if (done > 0) {
     createClients = false;
-    global.gc();
+    globalThis.gc();
     console.log(`done/collected/total: ${done}/${countGC}/${count}`);
     if (countGC === count) {
       server.close();

diff --git a/test/parallel/test-gc-tls-external-memory.js b/test/parallel/test-gc-tls-external-memory.js
@@ -27,7 +27,7 @@ connect();
 
 function connect() {
   if (runs % 64 === 0)
-    global.gc();
+    globalThis.gc();
   const externalMemoryUsage = process.memoryUsage().external;
   assert(externalMemoryUsage >= 0, `${externalMemoryUsage} < 0`);
   if (runs++ === 512) {

diff --git a/test/parallel/test-global-setters.js b/test/parallel/test-global-setters.js
@@ -8,20 +8,20 @@ assert.strictEqual(process, _process);
 // eslint-disable-next-line no-global-assign
 process = 'asdf';
 assert.strictEqual(process, 'asdf');
-assert.strictEqual(global.process, 'asdf');
-global.process = _process;
+assert.strictEqual(globalThis.process, 'asdf');
+globalThis.process = _process;
 assert.strictEqual(process, _process);
 assert.strictEqual(
-  typeof Object.getOwnPropertyDescriptor(global, 'process').get,
+  typeof Object.getOwnPropertyDescriptor(globalThis, 'process').get,
   'function');
 
 assert.strictEqual(Buffer, _Buffer);
 // eslint-disable-next-line no-global-assign
 Buffer = 'asdf';
 assert.strictEqual(Buffer, 'asdf');
-assert.strictEqual(global.Buffer, 'asdf');
-global.Buffer = _Buffer;
+assert.strictEqual(globalThis.Buffer, 'asdf');
+globalThis.Buffer = _Buffer;
 assert.strictEqual(Buffer, _Buffer);
 assert.strictEqual(
-  typeof Object.getOwnPropertyDescriptor(global, 'Buffer').get,
+  typeof Object.getOwnPropertyDescriptor(globalThis, 'Buffer').get,
   'function');
diff --git a/test/parallel/test-global.js b/test/parallel/test-global.js
@@ -60,9 +60,9 @@ for (const moduleName of builtinModules) {
     'crypto',
     'navigator',
   ];
-  assert.deepStrictEqual(new Set(Object.keys(global)), new Set(expected));
+  assert.deepStrictEqual(new Set(Object.keys(globalThis)), new Set(expected));
   expected.forEach((value) => {
-    const desc = Object.getOwnPropertyDescriptor(global, value);
+    const desc = Object.getOwnPropertyDescriptor(globalThis, value);
     if (typeof desc.value === 'function') {
       assert.strictEqual(desc.value.name, value);
     } else if (typeof desc.get === 'function') {
@@ -74,15 +74,15 @@ for (const moduleName of builtinModules) {
 common.allowGlobals('bar', 'foo');
 
 baseFoo = 'foo'; // eslint-disable-line no-undef
-global.baseBar = 'bar';
+globalThis.baseBar = 'bar';
 
-assert.strictEqual(global.baseFoo, 'foo',
-                   `x -> global.x failed: global.baseFoo = ${global.baseFoo}`);
+assert.strictEqual(globalThis.baseFoo, 'foo',
+                   `x -> globalThis.x failed: globalThis.baseFoo = ${globalThis.baseFoo}`);
 
 assert.strictEqual(baseBar, // eslint-disable-line no-undef
                    'bar',
                    // eslint-disable-next-line no-undef
-                   `global.x -> x failed: baseBar = ${baseBar}`);
+                   `globalThis.x -> x failed: baseBar = ${baseBar}`);
 
 const mod = require(fixtures.path('global', 'plain'));
 const fooBar = mod.fooBar;
@@ -91,4 +91,4 @@ assert.strictEqual(fooBar.foo, 'foo');
 
 assert.strictEqual(fooBar.bar, 'bar');
 
-assert.strictEqual(Object.prototype.toString.call(global), '[object global]');
+assert.strictEqual(Object.prototype.toString.call(globalThis), '[object global]');
diff --git a/test/parallel/test-h2leak-destroy-session-on-socket-ended.js b/test/parallel/test-h2leak-destroy-session-on-socket-ended.js
@@ -31,8 +31,8 @@ server.on('secureConnection', (s) => {
     firstServerStream = null;
 
     setImmediate(() => {
-      global.gc();
-      global.gc();
+      globalThis.gc();
+      globalThis.gc();
 
       server.close();
     });

diff --git a/test/parallel/test-heapdump-async-hooks-init-promise.js b/test/parallel/test-heapdump-async-hooks-init-promise.js
@@ -43,4 +43,4 @@ async_hooks.createHook({
 
 
 Promise.resolve().then(() => {});
-setImmediate(global.gc);
+setImmediate(globalThis.gc);
diff --git a/test/parallel/test-http-agent-domain-reused-gc.js b/test/parallel/test-http-agent-domain-reused-gc.js
@@ -26,7 +26,7 @@ async_hooks.createHook({
   },
   before(id) {
     if (id === reusedHandleId) {
-      global.gc();
+      globalThis.gc();
       checkBeforeCalled();
     }
   }

diff --git a/test/parallel/test-http-parser-bad-ref.js b/test/parallel/test-http-parser-bad-ref.js
@@ -18,7 +18,7 @@ let messagesComplete = 0;
 
 function flushPool() {
   Buffer.allocUnsafe(Buffer.poolSize - 1);
-  global.gc();
+  globalThis.gc();
 }
 
 function demoBug(part1, part2) {

diff --git a/test/parallel/test-http-server-connections-checking-leak.js b/test/parallel/test-http-server-connections-checking-leak.js
@@ -20,5 +20,5 @@ for (let i = 0; i < max; i++) {
 }
 
 setImmediate(() => {
-  global.gc();
+  globalThis.gc();
 });
Original file line number	Diff line number	Diff line change
Expand Up		@@ -43,4 +43,4 @@ async_hooks.createHook({


		Promise.resolve().then(() => {});
		setImmediate(global.gc);
		setImmediate(globalThis.gc);